Fix broken i.pca command in remote sensing tutorials#125
Merged
petrasovaa merged 1 commit intoJun 3, 2026
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Fixes the PCA tutorial snippets to use consistent band lists (no stray spaces) and correct GRASS Python API usage.
Changes:
- Normalized
i.pca input=...lists to remove an extra space after a comma in both PT and EN tutorials. - Fixed
gs.run_command(..., output=...)to pass the output map name as a string literal (and cleaned formatting).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| content/tutorials/remote_sensing_visualization/GRASS_remotesensing_pt.qmd | Aligns PCA bash/Python examples; fixes Python output argument quoting and input list formatting. |
| content/tutorials/remote_sensing_visualization/GRASS_remotesensing.qmd | Same corrections as PT version for consistency and correctness in English tutorial. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced Jun 3, 2026
petrasovaa
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #104
This PR fixes two issues in the PCA section of both the English and Portuguese remote sensing tutorials:
landsat8_2024_B4, landsat8_2024_B5(note the space after the comma) causesi.pcato fail in both the CLI and Python examples.output=Flagstaff_landsat8in the Python example references an undefined variable instead of the string"Flagstaff_landsat8", resulting in aNameError.The fixes have been applied to:
GRASS_remotesensing.qmdGRASS_remotesensing_pt.qmdThese changes ensure that all PCA examples run successfully as written.