Fix missing quotes on Python parameters in remote sensing tutorials#127
Merged
echoix merged 1 commit intoJun 3, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates GRASS GIS tutorial Python snippets to pass raster names and color rules as proper string arguments, aligning the examples with grass.script run_command expectations.
Changes:
- Quote
mapandcolorarguments ings.run_command("r.colors", ...)examples. - Quote
output,viname,red, andnirarguments ings.run_command("i.vi", ...)examples.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| content/tutorials/remote_sensing_visualization/GRASS_remotesensing_pt.qmd | Fixes Python example arguments by converting unquoted identifiers to strings. |
| content/tutorials/remote_sensing_visualization/GRASS_remotesensing.qmd | Applies the same string-quoting fixes to the English tutorial version. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
echoix
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The remote sensing tutorials (EN and PT) had 16 unquoted string parameters in two Python code blocks :
r.colorsandi.vi, that would raiseNameErrorwhen executed.r.colorsblock (×6 calls in each file):map=landsat8_2024_B2→map="landsat8_2024_B2"color=grey→color="grey"i.viblock:output=Flagstaff_NDVI→output="Flagstaff_NDVI"viname=ndvi→viname="ndvi"red=landsat8_2024_B4→red="landsat8_2024_B4"nir=landsat8_2024_B5→nir="landsat8_2024_B5"Applied to both
GRASS_remotesensing.qmdandGRASS_remotesensing_pt.qmd. Thei.pcaquoting fix in the same files is covered separately in PR #125.