Increase test coverage by Copilot · Pull Request #8316 · wp-media/wp-rocket

Copilot · 2026-05-18T23:23:45Z

I was trying to ask copilot to create a PR for this issue: #8315 but he added more tests to what we have on develop so I fixed them and it doesn't hurt having it into develop directly and I'll start another PR for adding more test coverage for API integration PR.

codacy-production · 2026-05-18T23:24:41Z

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results

Complexity 0

Duplication 0

View in Codacy

🟢 Coverage 100.00% diff coverage · +0.22% coverage variation

Metric Results

Coverage variation ✅ +0.22% coverage variation (-0.10%)

Diff coverage ✅ 100.00% diff coverage (50.00%)

View coverage diff in Codacy

Coverage variation details

Coverable lines Covered lines Coverage

Common ancestor commit (d3f6e54) Report Missing Report Missing Report Missing

Head commit (52d3adc) 43092 (+0) 19927 (+93) 46.24% (+0.22%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

Coverable lines Covered lines Diff coverage

Pull request (#8316) 1 1 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

¹ Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

_{NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer}
_{TIP This summary will be updated as you push new changes.}

Agent-Logs-Url: https://github.com/wp-media/wp-rocket/sessions/3aa33159-615a-4459-a794-e82b26c5e20b Co-authored-by: wordpressfan <146129302+wordpressfan@users.noreply.github.com>

Agent-Logs-Url: https://github.com/wp-media/wp-rocket/sessions/253474cc-6ffc-4849-be23-ac17e532f2fc Co-authored-by: wordpressfan <146129302+wordpressfan@users.noreply.github.com>

Copilot

Pull request overview

This PR increases automated test coverage for the License/API “Rocket Insights” integration layer by adding a broad set of unit fixtures + test cases (and one integration test), plus a small hardening change in User::get_rocket_insights_addon_btn_url().

Changes:

Added unit tests (with fixtures) covering User, RemoteSettings, RemoteSettingsClient, and Currency behaviors.
Added an integration test for RemoteSettingsClient::get_remote_settings_data() using transient + HTTP preemption scenarios.
Updated User::get_rocket_insights_addon_btn_url() to use rocket_get_constant( 'WP_ROCKET_PLUGIN_SLUG' ) instead of a direct constant reference.

Reviewed changes

Copilot reviewed 46 out of 46 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
inc/Engine/License/API/User.php	Uses `rocket_get_constant()` for the plugin slug when building the Rocket Insights upgrade URL.
tests/Integration/inc/Engine/License/API/RemoteSettingsClientGetRemoteSettingsData.php	Integration coverage for cached/timeout/HTTP-response paths of remote settings retrieval.
tests/Fixtures/inc/Engine/License/API/CurrencyFormatPriceWithCurrencySymbol.php	Fixture data for formatting prices with currency symbols (span wrapping/spacing cases).
tests/Fixtures/inc/Engine/License/API/CurrencyGetSymbol.php	Fixture data for currency symbol mapping cases.
tests/Fixtures/inc/Engine/License/API/CurrencyIsEuro.php	Fixture data for `Currency::is_euro()` cases.
tests/Fixtures/inc/Engine/License/API/RemoteSettingsClientGetRemoteSettingsData.php	Fixture data for remote settings client cached/timeout/error/success paths.
tests/Fixtures/inc/Engine/License/API/RemoteSettingsIsRemoteSettingEnabled.php	Fixture data for enabled/disabled/missing remote-setting flag cases.
tests/Fixtures/inc/Engine/License/API/User/getCurrency.php	Fixture data for currency defaults and explicit currency values.
tests/Fixtures/inc/Engine/License/API/User/getRocketInsightsAddonBilling.php	Fixture data for addon billing text retrieval/translation behavior.
tests/Fixtures/inc/Engine/License/API/User/getRocketInsightsAddonBtnText.php	Fixture data for addon button label retrieval/translation behavior.
tests/Fixtures/inc/Engine/License/API/User/getRocketInsightsAddonBtnUrl.php	Fixture data for addon button URL behavior, including dashboard URL query arg.
tests/Fixtures/inc/Engine/License/API/User/getRocketInsightsAddonHighlights.php	Fixture data for addon highlights retrieval + translation behavior.
tests/Fixtures/inc/Engine/License/API/User/getRocketInsightsAddonLimit.php	Fixture data for addon plan limit behavior and defaults.
tests/Fixtures/inc/Engine/License/API/User/getRocketInsightsAddonPrice.php	Fixture data for addon price retrieval and missing-data behavior.
tests/Fixtures/inc/Engine/License/API/User/getRocketInsightsAddonPromoBilling.php	Fixture data for promo billing retrieval + translation behavior.
tests/Fixtures/inc/Engine/License/API/User/getRocketInsightsAddonPromoName.php	Fixture data for promo name retrieval + translation behavior.
tests/Fixtures/inc/Engine/License/API/User/getRocketInsightsAddonPromoPrice.php	Fixture data for promo price retrieval and expiry checks.
tests/Fixtures/inc/Engine/License/API/User/getRocketInsightsAddonSkuActive.php	Fixture data for active addon SKU selection and defaults.
tests/Fixtures/inc/Engine/License/API/User/getRocketInsightsAddonSubtitle.php	Fixture data for subtitle retrieval + translation behavior.
tests/Fixtures/inc/Engine/License/API/User/getRocketInsightsAddonUpgradeSkus.php	Fixture data for upgrade SKU list retrieval and missing-data cases.
tests/Fixtures/inc/Engine/License/API/User/getRocketInsightsLicenseExpiration.php	Fixture data for addon license expiration retrieval and casting behavior.
tests/Fixtures/inc/Engine/License/API/User/hasRocketInsightsAddonPromo.php	Fixture data for promo presence/expiry edge cases.
tests/Fixtures/inc/Engine/License/API/User/isRocketInsightsAddonActive.php	Fixture data for paid-vs-free SKU detection.
tests/Fixtures/inc/Engine/License/API/User/isRocketInsightsFreeActive.php	Fixture data for free SKU detection.
tests/Unit/inc/Engine/License/API/CurrencyFormatPriceWithCurrencySymbol.php	Unit test for `Currency::format_price_with_currency_symbol()`.
tests/Unit/inc/Engine/License/API/CurrencyGetSymbol.php	Unit test for `Currency::get_symbol()`.
tests/Unit/inc/Engine/License/API/CurrencyIsEuro.php	Unit test for `Currency::is_euro()`.
tests/Unit/inc/Engine/License/API/RemoteSettingsClientGetRemoteSettingsData.php	Unit test for remote settings client behavior (HTTP success/failure + timeout transients).
tests/Unit/inc/Engine/License/API/RemoteSettingsIsRemoteSettingEnabled.php	Unit test for `RemoteSettings::is_rocket_insights_remote_setting_enabled()`.
tests/Unit/inc/Engine/License/API/User/getCurrency.php	Unit test for `User::get_currency()`.
tests/Unit/inc/Engine/License/API/User/getRocketInsightsAddonBilling.php	Unit test for `User::get_rocket_insights_addon_billing()`.
tests/Unit/inc/Engine/License/API/User/getRocketInsightsAddonBtnText.php	Unit test for `User::get_rocket_insights_addon_btn_text()`.
tests/Unit/inc/Engine/License/API/User/getRocketInsightsAddonBtnUrl.php	Unit test for `User::get_rocket_insights_addon_btn_url()`.
tests/Unit/inc/Engine/License/API/User/getRocketInsightsAddonHighlights.php	Unit test for `User::get_rocket_insights_addon_highlights()`.
tests/Unit/inc/Engine/License/API/User/getRocketInsightsAddonLimit.php	Unit test for `User::get_rocket_insights_addon_limit()`.
tests/Unit/inc/Engine/License/API/User/getRocketInsightsAddonPrice.php	Unit test for `User::get_rocket_insights_addon_price()`.
tests/Unit/inc/Engine/License/API/User/getRocketInsightsAddonPromoBilling.php	Unit test for `User::get_rocket_insights_addon_promo_billing()`.
tests/Unit/inc/Engine/License/API/User/getRocketInsightsAddonPromoName.php	Unit test for `User::get_rocket_insights_addon_promo_name()`.
tests/Unit/inc/Engine/License/API/User/getRocketInsightsAddonPromoPrice.php	Unit test for `User::get_rocket_insights_addon_promo_price()`.
tests/Unit/inc/Engine/License/API/User/getRocketInsightsAddonSkuActive.php	Unit test for `User::get_rocket_insights_addon_sku_active()`.
tests/Unit/inc/Engine/License/API/User/getRocketInsightsAddonSubtitle.php	Unit test for `User::get_rocket_insights_addon_subtitle()`.
tests/Unit/inc/Engine/License/API/User/getRocketInsightsAddonUpgradeSkus.php	Unit test for `User::get_rocket_insights_addon_upgrade_skus()`.
tests/Unit/inc/Engine/License/API/User/getRocketInsightsLicenseExpiration.php	Unit test for `User::get_rocket_insights_license_expiration()`.
tests/Unit/inc/Engine/License/API/User/hasRocketInsightsAddonPromo.php	Unit test for `User::has_rocket_insights_addon_promo()`.
tests/Unit/inc/Engine/License/API/User/isRocketInsightsAddonActive.php	Unit test for `User::is_rocket_insights_addon_active()`.
tests/Unit/inc/Engine/License/API/User/isRocketInsightsFreeActive.php	Unit test for `User::is_rocket_insights_free_active()`.

+class GetRocketInsightsAddonBtnUrl extends TestCase {
+	use StubTrait;


+class RemoteSettingsClientGetRemoteSettingsData extends TestCase {
+	use StubTrait;
+	private $client;


+class RemoteSettingsClientGetRemoteSettingsData extends TestCase {
+	use StubTrait;
+	private static $client;


Initial plan

a1e9ed2

Copilot AI assigned Copilot and wordpressfan May 18, 2026

Copilot started work on behalf of wordpressfan May 18, 2026 23:23 View session

Copilot AI linked an issue May 18, 2026 that may be closed by this pull request

Increase test coverage for API integration part #8315

Closed

Copilot AI and others added 2 commits May 18, 2026 23:49

Add unit and integration tests for API integration coverage

82cfca5

Agent-Logs-Url: https://github.com/wp-media/wp-rocket/sessions/3aa33159-615a-4459-a794-e82b26c5e20b Co-authored-by: wordpressfan <146129302+wordpressfan@users.noreply.github.com>

Add tests for Currency class and new User methods

51d0b2b

Agent-Logs-Url: https://github.com/wp-media/wp-rocket/sessions/3aa33159-615a-4459-a794-e82b26c5e20b Co-authored-by: wordpressfan <146129302+wordpressfan@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Add unit and integration tests for API integration~~ Add unit and integration tests for API integration (remote settings, currency, user methods) May 18, 2026

Copilot finished work on behalf of wordpressfan May 18, 2026 23:52

Copilot AI requested a review from wordpressfan May 18, 2026 23:52

Copilot started work on behalf of wordpressfan May 19, 2026 04:56 View session

Add remaining User addon method tests for full PR #8310 coverage

de87629

Agent-Logs-Url: https://github.com/wp-media/wp-rocket/sessions/253474cc-6ffc-4849-be23-ac17e532f2fc Co-authored-by: wordpressfan <146129302+wordpressfan@users.noreply.github.com>

Copilot finished work on behalf of wordpressfan May 19, 2026 05:05

fix failed tests

204b4f8

wordpressfan removed a link to an issue May 19, 2026

Increase test coverage for API integration part #8315

Closed

wordpressfan changed the title ~~Add unit and integration tests for API integration (remote settings, currency, user methods)~~ Increase test coverage May 19, 2026

fix failed integration tests

52d3adc

wordpressfan marked this pull request as ready for review May 19, 2026 06:13

Copilot AI review requested due to automatic review settings May 19, 2026 06:13

Copilot started reviewing on behalf of wordpressfan May 19, 2026 06:13 View session

Copilot AI reviewed May 19, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Increase test coverage#8316

Increase test coverage#8316
Copilot wants to merge 6 commits into
developfrom
copilot/featureincrease-test-coverage-api-integration

Copilot AI commented May 18, 2026 •

edited by wordpressfan

Loading

Uh oh!

codacy-production Bot commented May 18, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		class GetRocketInsightsAddonBtnUrl extends TestCase {
		use StubTrait;

Conversation

Copilot AI commented May 18, 2026 • edited by wordpressfan Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codacy-production Bot commented May 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Up to standards ✅

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented May 18, 2026 •

edited by wordpressfan

Loading

codacy-production Bot commented May 18, 2026 •

edited

Loading