Reject registerTool() promise when signal is aborted#202
Merged
domfarolino merged 3 commits intoJun 17, 2026
Conversation
beaufortfrancois
changed the title
Contributor
Author
|
@domfarolino Please review |
beaufortfrancois
commented
Jun 9, 2026
beaufortfrancois
changed the title
domfarolino
reviewed
Jun 16, 2026
beaufortfrancois
force-pushed
the
promise-signal
branch
from
8b46545 to
7526883
Compare
NoClueMike
approved these changes
Jun 17, 2026
domfarolino
approved these changes
Jun 17, 2026
github-actions Bot
added a commit
that referenced
this pull request
Jun 17, 2026
SHA: bc93f03 Reason: push, by domfarolino Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe we should reject
registerTool()promise when signal is aborted instead now following #200 changesIt's part of changes required for #175.
Preview | Diff