Spec: Jujutsu (jj) prompt chips (GH-11797)#12049
Conversation
- product.md: 13 behavior invariants for JjBookmark and JjDirtyItems chips - tech.md: implementation plan mirroring SVN chip pattern with file:line references
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @metanmai on file. In order for us to review and merge your code, each contributor must visit https://cla.warp.dev to read and agree to our CLA. Once you have done so, please comment |
github-actions
Bot
added
the
external-contributor
|
I'm starting a first review of this spec-only pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
This spec adds product and technical plans for two Jujutsu prompt chips: JjBookmark and JjDirtyItems.
Concerns
- The rendering requirements conflict between the product and tech specs for
JjBookmarkcolors. - The proposed adjacent-spacing change only handles
JjBookmarkfollowed byJjDirtyItems, but the product spec requires no space in either order. - The shell-command plan calls out PowerShell ports but omits a Fish-compatible
jj_bookmark()variant, even though the proposed POSIX snippet uses syntax Fish will not run.
Verdict
Found: 0 critical, 3 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
|
Every PR must be linked to a same-repo issue before Oz can review it. Next step: open or find a same-repo issue describing this change, then link it to this PR by adding See the contribution guidelines for the full readiness model. Powered by Oz |
There was a problem hiding this comment.
Every PR must be linked to a same-repo issue before Oz can review it.
Next step: open or find a same-repo issue describing this change, then link it to this PR by adding Closes #123 to the PR description (or using the "Development" sidebar on GitHub). A maintainer will mark the issue ready-to-spec when it is ready. Once it is marked, comment /oz-review to re-trigger review.
See the contribution guidelines for the full readiness model.
Powered by Oz
|
/oz-review |
|
I'm re-reviewing this spec-only pull request in response to a review request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
There was a problem hiding this comment.
Overview
This spec adds product and technical coverage for Jujutsu prompt chips, including behavior invariants and an implementation plan that follows the existing SVN chip pattern.
Concerns
- The PowerShell command sample is not valid PowerShell as written, so implementers could copy a broken shell variant.
- The testing section should explicitly cover every shell-specific command variant so Bash/Zsh, Fish, and PowerShell behavior cannot drift.
Verdict
Found: 0 critical, 1 important, 1 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
| |---|---| | ||
| | 1. Chips appear in picker UI | Unit test in `builtins_tests.rs`: verify `available_chips()` includes both new variants | | ||
| | 2. Runtime disable when `jj` absent | Unit test in `current_prompt_tests.rs`: mirror `test_shell_chip_disabled_when_executable_is_missing` for `jj` | | ||
| | 3–5. JjBookmark display text | Shell command test: run `jj log` in a `jj` repo with various states and verify output format | |
There was a problem hiding this comment.
💡 [SUGGESTION] Require validation for each shell-specific command variant, including Bash/Zsh, Fish, and PowerShell, plus clean and no-repository cases.
PowerShell uses backtick (`) for line continuation, not backslash (\). 💘 Generated with Crush Assisted-by: Crush:deepseek/deepseek-v4-pro
1 participant
Summary
Add two new prompt context chips for the
jj(Jujutsu) VCS: JjBookmark (bookmark/change display) and JjDirtyItems (changed-file count), mirroring the existing SvnBranch / SvnDirtyItems chip pattern.Closes #11797.
Files
specs/GH11797/product.md— 13 behavior invariantsspecs/GH11797/tech.md— implementation plan with file:line references