enable cross-window tab dragging in preview#12046
Conversation
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
There was a problem hiding this comment.
Overview
This PR promotes DragTabsToWindows from Dogfood to Preview by adding it to PREVIEW_FLAGS.
Concerns
- The PR description calls out an unreproduced random crash on Windows, but the new Preview flag entry enables the feature for Windows Preview users too.
- This is a user-facing behavior change, but the PR description does not include screenshots or a screen recording demonstrating cross-window tab dragging working end to end.
Verdict
Found: 0 critical, 2 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
| pub const PREVIEW_FLAGS: &[FeatureFlag] = &[ | ||
| FeatureFlag::DragTabsToWindows, | ||
| ]; |
There was a problem hiding this comment.
| pub const PREVIEW_FLAGS: &[FeatureFlag] = &[ | |
| FeatureFlag::DragTabsToWindows, | |
| ]; | |
| pub const PREVIEW_FLAGS: &[FeatureFlag] = &[ | |
| #[cfg(not(windows))] | |
| FeatureFlag::DragTabsToWindows, | |
| ]; |
This PR enables tab dragging in preview. There are two main issues:
#1 is not trivial to fix, and I'm deliberately scoping out of Preview. I'll take another pass before considering this feature for Stable.
I'm hoping to leverage Preview users to hone in on #2, but will continue to attempt to reproduce until the Preview release on Thursday.