Skip to content

enable cross-window tab dragging in preview#12046

Open
peicodes wants to merge 2 commits into
masterfrom
pei/tab-dragging-preview
Open

enable cross-window tab dragging in preview#12046
peicodes wants to merge 2 commits into
masterfrom
pei/tab-dragging-preview

Conversation

@peicodes
Copy link
Copy Markdown
Contributor

@peicodes peicodes commented Jun 2, 2026

This PR enables tab dragging in preview. There are two main issues:

  1. Dragging a tab out and in repeatedly in the same mousedown doesn't work: investigation for tab-redragging #12044
  2. @acarl005 reported a random crash on Windows. I tried using a VM to reproduce but have been unsuccessful.

#1 is not trivial to fix, and I'm deliberately scoping out of Preview. I'll take another pass before considering this feature for Stable.

I'm hoping to leverage Preview users to hone in on #2, but will continue to attempt to reproduce until the Preview release on Thursday.

@cla-bot cla-bot Bot added the cla-signed label Jun 2, 2026
@oz-for-oss
Copy link
Copy Markdown
Contributor

oz-for-oss Bot commented Jun 2, 2026

@peicodes

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

@peicodes peicodes requested a review from alokedesai June 2, 2026 01:55
Copy link
Copy Markdown
Contributor

@oz-for-oss oz-for-oss Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview

This PR promotes DragTabsToWindows from Dogfood to Preview by adding it to PREVIEW_FLAGS.

Concerns

  • The PR description calls out an unreproduced random crash on Windows, but the new Preview flag entry enables the feature for Windows Preview users too.
  • This is a user-facing behavior change, but the PR description does not include screenshots or a screen recording demonstrating cross-window tab dragging working end to end.

Verdict

Found: 0 critical, 2 important, 0 suggestions

Request changes

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

Comment thread crates/warp_features/src/lib.rs Outdated
Comment on lines +962 to +964
pub const PREVIEW_FLAGS: &[FeatureFlag] = &[
FeatureFlag::DragTabsToWindows,
];
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [IMPORTANT] The PR description calls out an unreproduced Windows crash, but this promotes the flag to Preview for Windows users too. Gate the Preview entry on non-Windows until the crash is fixed or ruled out.

Suggested change
pub const PREVIEW_FLAGS: &[FeatureFlag] = &[
FeatureFlag::DragTabsToWindows,
];
pub const PREVIEW_FLAGS: &[FeatureFlag] = &[
#[cfg(not(windows))]
FeatureFlag::DragTabsToWindows,
];

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants