fix(createRegistry): remove spurious non-null assertions in seek()#282
Open
sridhar-3009 wants to merge 1 commit into
Open
Conversation
Both `tickets[i]!` occurrences in the `last` and `first` loops are unnecessary. `tickets` is typed `readonly E[]` and neither `noUncheckedIndexedAccess` is enabled nor are the loop bounds unchecked, so `tickets[i]` is already typed `E`. The `!` adds noise without any runtime or type-level benefit. Closes vuetifyjs#281
|
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #281
Both
tickets[i]!occurrences inseek()are unnecessary:ticketsis the result ofvalues(), typedreadonly E[]noUncheckedIndexedAccessis enabled in the relevant tsconfig (tsconfig.dom.jsonbase, nottsconfig.lib.json)i >= 0/i < tickets.length), so the index is always in rangeDropping the
!removes noise without any behavior change. These are the last spurious assertions increateRegistry/index.ts— the remaining ones (listeners.get(event)!,get(id)!) document genuine Map invariants and are intentionally left as-is.