Skip to content

Rename percision to accuracy#8214

Open
AdamGS wants to merge 1 commit into
developfrom
adamg/rename-percision-to-accuracy
Open

Rename percision to accuracy#8214
AdamGS wants to merge 1 commit into
developfrom
adamg/rename-percision-to-accuracy

Conversation

@AdamGS
Copy link
Copy Markdown
Contributor

@AdamGS AdamGS commented Jun 2, 2026

Summary

This PR renames the Precision enum that we use to do array hashing and equality checks to Accuracy, as we already have a Precision enum we use for stats, that is also part of the binary format.

API Changes

Just the renamed enum, which should be relatively minor.

Testing

N/A

Signed-off-by: Adam Gutglick <adam@spiraldb.com>
@AdamGS AdamGS added the changelog/chore A trivial change label Jun 2, 2026
@AdamGS AdamGS requested review from a10y, gatesn and joseph-isaacs and removed request for a10y, gatesn and joseph-isaacs June 2, 2026 12:54
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Jun 2, 2026

Merging this PR will improve performance by 13.42%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚡ 2 improved benchmarks
✅ 1273 untouched benchmarks

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation take_map[(0.1, 1.0)] 1.9 ms 1.7 ms +16.15%
Simulation take_map[(0.1, 0.5)] 1,092.6 µs 986.5 µs +10.75%

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.


Comparing adamg/rename-percision-to-accuracy (8e186ed) with develop (5aa3f3d)

Open in CodSpeed

Copy link
Copy Markdown
Contributor

@joseph-isaacs joseph-isaacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

accuracy is the wrong word

@joseph-isaacs
Copy link
Copy Markdown
Contributor

exactness?

@AdamGS
Copy link
Copy Markdown
Contributor Author

AdamGS commented Jun 2, 2026

how about splitting it into two functions on the same trait? the enum seems confusing

@a10y
Copy link
Copy Markdown
Contributor

a10y commented Jun 2, 2026

should we just call this EqMode or something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants