Skip to content

Block deleting protected VikingFS roots#2873

Open
ZaynJarvis wants to merge 1 commit into
mainfrom
luna/block-root-user-rm
Open

Block deleting protected VikingFS roots#2873
ZaynJarvis wants to merge 1 commit into
mainfrom
luna/block-root-user-rm

Conversation

@ZaynJarvis

@ZaynJarvis ZaynJarvis commented Jun 27, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • add a delete-specific VikingFS access guard for rm()
  • reject deletes of viking:// and viking://user aliases before AGFS/vector-store side effects
  • keep public roots on the normal delete path, with session root verified as current-user scoped
  • preserve existing non-root temp-root delete protection

Tests

  • uv run --frozen --extra test python -m pytest -q tests/misc/test_vikingfs_uri_guard.py (27 passed)

Review notes

  • Bob reviewed the first version and confirmed write/mkdir/mv are unaffected
  • Follow-up tests cover his session-root and temp-root delete-path concerns

@ZaynJarvis ZaynJarvis force-pushed the luna/block-root-user-rm branch from fdbf47a to 3e80c21 Compare June 27, 2026 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

1 participant