Skip to content

Update lint and test Github workflows; add Python 3.13 and 3.14 tests#27

Open
davidpirogov wants to merge 1 commit into
mainfrom
fix/update-github-tests
Open

Update lint and test Github workflows; add Python 3.13 and 3.14 tests#27
davidpirogov wants to merge 1 commit into
mainfrom
fix/update-github-tests

Conversation

@davidpirogov

@davidpirogov davidpirogov commented Nov 9, 2025

Copy link
Copy Markdown
Contributor

Description

Added Python 3.13 and 3.14 tests to Github Actions.

Added more restrictive permissions to the Github Workflows to ensure that we're only giving limited permissions to actions. (No effective change to current Github Workflows, just makes them more secure)

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring (no functional changes)
  • Performance improvement
  • Test coverage improvement

@davidpirogov davidpirogov requested a review from a team as a code owner November 9, 2025 10:30
@davidpirogov

Copy link
Copy Markdown
Contributor Author

Failing 3.8 tests will be fixed once PR #24 is approved and merged. (expected failure)

@Justar96

Justar96 commented Nov 9, 2025

Copy link
Copy Markdown
Contributor

@davidpirogov and let's wait for #24 to be merged first
These should be in [dependency-groups.dev]

  • Runtime deps should be minimal (dev tool, not runtime dependency)
[dependency-groups]
benchmark = ["tiktoken>=0.4.0"]
dev = [
    "pytest>=8.0.0",
    "pytest-cov>=4.1.0",
    "ruff>=0.8.0",
    "mypy>=1.8.0",
]

@johannschopplich

Copy link
Copy Markdown
Contributor

@alesanfra this one's been sitting for a while and looks solid to me – happy if you want to take a quick look and merge if it checks out! 🙌

@alesanfra alesanfra left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you please look into the failing checks? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants