Skip to content

test: verify both wait strategies in WaitAllStrategyTest#11830

Open
codingkiddo wants to merge 1 commit into
testcontainers:mainfrom
codingkiddo:test/fix-wait-all-strategy-verifications
Open

test: verify both wait strategies in WaitAllStrategyTest#11830
codingkiddo wants to merge 1 commit into
testcontainers:mainfrom
codingkiddo:test/fix-wait-all-strategy-verifications

Conversation

@codingkiddo
Copy link
Copy Markdown

Summary

Fix a copy-paste issue in WaitAllStrategyTest.

Two tests were verifying strategy1 twice and never verifying strategy2. As a result, the tests did not fully assert behavior for both configured wait strategies.

Changes

  • Update shouldNotMessWithIndividualTimeouts to verify that strategy2 does not receive an individual startup timeout.
  • Update shouldOverwriteIndividualTimeouts to verify that strategy2 receives the configured startup timeout.
  • No production code changes.

Testing

Ran the focused test:

./gradlew :testcontainers:test --tests org.testcontainers.containers.wait.strategy.WaitAllStrategyTest

Also ran formatting/check commands as requested:

./gradlew checkstyleMain checkstyleTest spotlessApply

Signed-off-by: Vinod Kumar <codingkiddo@gmail.com>
@codingkiddo codingkiddo requested a review from a team as a code owner June 4, 2026 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant