Skip to content

feat(web): company brain — invite-accept page, space UX/visibility, org-scoped daily brief#1112

Open
MaheshtheDev wants to merge 1 commit into
graphite-base/1112from
company-brain-invite-accept
Open

feat(web): company brain — invite-accept page, space UX/visibility, org-scoped daily brief#1112
MaheshtheDev wants to merge 1 commit into
graphite-base/1112from
company-brain-invite-accept

Conversation

@MaheshtheDev

@MaheshtheDev MaheshtheDev commented Jun 13, 2026

Copy link
Copy Markdown
Member

New /org/invite/[invitationId] page so consumer-org invitees can view and accept or decline invitations in the app instead of the console.

Fixes ENG-811

MaheshtheDev commented Jun 13, 2026

Copy link
Copy Markdown
Member Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add the label Main to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jun 13, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
supermemory-mcp 51ce30a Jun 18 2026, 12:27 AM

@linear-code

linear-code Bot commented Jun 13, 2026

Copy link
Copy Markdown

ENG-811

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jun 13, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
supermemory-app 51ce30a Commit Preview URL

Branch Preview URL
Jun 18 2026, 12:30 AM

@MaheshtheDev MaheshtheDev force-pushed the company-brain-invite-accept branch 3 times, most recently from 2986b03 to d5555ba Compare June 13, 2026 16:59
@MaheshtheDev MaheshtheDev force-pushed the company-control-0612 branch from 5377aa3 to b5e5337 Compare June 13, 2026 16:59
@MaheshtheDev MaheshtheDev force-pushed the company-brain-invite-accept branch from 62e5636 to f3972ab Compare June 14, 2026 08:09
@MaheshtheDev MaheshtheDev force-pushed the company-control-0612 branch from b5e5337 to 2d8845e Compare June 14, 2026 08:09
@MaheshtheDev MaheshtheDev changed the title feat(web): add org invite accept page feat(web): company brain — invite-accept page, space UX/visibility, org-scoped daily brief Jun 14, 2026
@MaheshtheDev MaheshtheDev force-pushed the company-brain-invite-accept branch from a361d78 to dd013ee Compare June 14, 2026 18:06
@MaheshtheDev MaheshtheDev force-pushed the company-control-0612 branch from 2d8845e to dab2ff9 Compare June 14, 2026 18:06
@MaheshtheDev MaheshtheDev force-pushed the company-brain-invite-accept branch from dd013ee to e28b804 Compare June 14, 2026 20:21
@MaheshtheDev MaheshtheDev force-pushed the company-control-0612 branch from dab2ff9 to c829fd3 Compare June 17, 2026 23:36
@MaheshtheDev MaheshtheDev force-pushed the company-brain-invite-accept branch from e28b804 to 4711718 Compare June 17, 2026 23:36
…nvite-accept

Space selector (My Brain/Team Brain), invite-accept page, create-org launches onboarding (?new=1) with the popover→dialog pointer-events fix, owner-gated account settings, org-scoped page.
@MaheshtheDev MaheshtheDev force-pushed the company-brain-invite-accept branch from 4711718 to 51ce30a Compare June 18, 2026 00:26
@MaheshtheDev MaheshtheDev marked this pull request as ready for review June 18, 2026 04:52
@graphite-app graphite-app Bot requested a review from Dhravya June 18, 2026 04:52
@claude

claude Bot commented Jun 18, 2026

Copy link
Copy Markdown

Claude finished @MaheshtheDev's task in 2m 3s —— View job


PR Review Complete

  • Loading review tools
  • Fetching PR diff and existing review comments
  • Analyzing changed files for bugs and security issues
  • Submitting review

Summary: Reviewed all 7 changed files for bugs, security issues, and logic errors. No issues found — this PR is clean and ready to ship.

Key findings:

  • Invite page has proper error handling, cleanup, and secure redirect URL encoding
  • Role detection change improves security by defaulting to least privilege when members aren't loaded
  • Space selector correctly handles company brain org defaults
  • All dependency arrays in hooks are properly updated

Score: 10/10

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview: Adds an invite-accept page for org invitations, improves space selector UX for company brain orgs, and makes role detection more robust by defaulting to least privilege.

Issues found: None — this looks good to ship.

Analysis:

  1. Invite page (apps/web/app/org/invite/[invitationId]/page.tsx): Clean implementation with proper error handling, cleanup via cancelled flag in useEffect, correct expiration checking, and secure redirect URL encoding with encodeURIComponent. Authorization is handled server-side (403 → wrong_account).

  2. Role detection (apps/web/components/settings/account.tsx): The change to check membersLoaded before assuming single-member-personal-org is a security improvement — it now defaults to "member" (least privilege) when members aren't loaded, rather than incorrectly granting "owner".

  3. Space selector changes: Logic correctly switches default from DEFAULT_PROJECT_ID to SHARED_TEAM_BRAIN_TAG for company brain orgs. Dependencies in useMemo are properly updated.

  4. Org creation flow (settings-org-switcher.tsx): Clean redirect to onboarding with the new ?new=1&name= params. The pointer-events workaround for Radix overlay is a pragmatic fix for a known UX issue.

  5. Memory-of-day cache key (page.tsx): Adding org?.id to the cache key ensures org-scoped daily briefs — correct fix.

Score: 10/10

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 51ce30a6b6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread apps/web/app/(app)/onboarding/page.tsx
@MaheshtheDev MaheshtheDev changed the base branch from company-control-0612 to graphite-base/1112 June 18, 2026 15:24

@sreedharsreeram sreedharsreeram left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants