Skip to content

Grok 4.3, web sources UX, and mobile polish#1064

Merged
ishaanxgupta merged 1 commit into
mainfrom
mahesh/nova-chat-polish
Jun 8, 2026
Merged

Grok 4.3, web sources UX, and mobile polish#1064
ishaanxgupta merged 1 commit into
mainfrom
mahesh/nova-chat-polish

Conversation

@MaheshtheDev

Copy link
Copy Markdown
Member

Stacked on top of #1004 (Nova chat attachments). Builds on that branch with model, web-source, and mobile improvements.

Grok 4.3

  • Add Grok 4.3 as a selectable model and the default

Composer toolbar (web)

  • Reorder to model · attach · reasoning … space · send (new toolbarTrailing/toolbarEnd slots)
  • Icon-only reasoning click-toggle (Instant ↔ Thinking) with hover label + directional roll
  • Lighter model dropdown (translucent surface, subtle selected row, open/close animation, chevron rotation)
  • Borderless ghost controls; loader lives in the composer status strip ("Searching the web…" / "Thinking…")

Web sources / citations

  • Single favicon sources pill (hover-reveal), citation hover cards (favicon + domain/path)
  • Web-search indicator collapsed to one status-strip line (no stuck spinners)
  • Merge text runs split by source-url; keep source parts on thread reload
  • Strip tool parts on send (fixes tool_use/tool_result mismatch on follow-ups)

Mobile

  • Sticky full-width bottom bar (icon-over-label), Nova orb centered
  • Chat view fixed to h-dvh → composer pinned; back button in chat; nav hidden in chat
  • Safe-area + spacing fixes for the home composer

Fixes

  • SelectSpacesModal a11y (DialogTitle)
  • Delete-document toast surfaces the real server error
  • Markdown: hide redundant ---, fix detached list bullets

@graphite-app graphite-app Bot requested a review from Dhravya June 8, 2026 05:54
@claude

claude Bot commented Jun 8, 2026

Copy link
Copy Markdown

Claude finished @MaheshtheDev's task in 2m 11s —— View job


Review Complete

  • Fetch PR diff and existing review comments
  • Analyze changes for bugs, security issues, and logic errors
  • Review tool parts sanitization logic
  • Review citation/web sources implementation
  • Review mobile layout changes
  • Submit review findings

Overview: Adds Grok 4.3 as the default model, improves web sources UX with citation hover cards and a collapsible sources pill, fixes mobile layout/navigation, and addresses several bugs including tool_use/tool_result mismatches and a11y issues.

Issues found: None — this looks good to ship.

Key changes reviewed:

  • Tool parts sanitization (index.tsx:356-363): Correctly strips tool parts before sending to backend, fixing the tool_use/tool_result mismatch on follow-up messages.

  • Text run merging (agent-message.tsx:583-599): Properly coalesces text parts split by source-url citations to prevent broken markdown rendering.

  • Citation hover cards (agent-message.tsx:72-120): Clean implementation with proper URL parsing and graceful fallbacks.

  • WebSourcesPill click-outside (agent-message.tsx:171-181): Correct useEffect cleanup — no memory leak.

  • A11y fix (select-spaces-modal.tsx): Changed <p> to <DialogTitle> for screen reader accessibility.

  • Error message extraction (use-document-mutations.ts:10-19): Handles {error}, {message}, and string formats cleanly.

Score: 9/10

Solid PR with good attention to edge cases.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jun 8, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
supermemory-mcp 023ea8e Jun 08 2026, 06:21 AM

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jun 8, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
supermemory-app 023ea8e Commit Preview URL

Branch Preview URL
Jun 08 2026, 06:22 AM

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview: Adds Grok 4.3 as the default model, improves web sources UX with citation hover cards and a collapsible sources pill, fixes mobile layout/navigation, and addresses several bugs including tool_use/tool_result mismatches and a11y issues.

Issues found: None — this looks good to ship.

Key changes reviewed:

  • Tool parts sanitization (index.tsx:356-363): Correctly strips tool parts before sending to backend, fixing the tool_use/tool_result mismatch on follow-up messages.
  • Text run merging (agent-message.tsx:583-599): Properly coalesces text parts split by source-url citations to prevent broken markdown rendering.
  • Citation hover cards (agent-message.tsx:72-120): Clean implementation with proper URL parsing and graceful fallbacks.
  • A11y fix (select-spaces-modal.tsx): Added missing DialogTitle — good catch.
  • Error message extraction (use-document-mutations.ts): The new fetchErrorMessage helper handles multiple error formats cleanly.

Score: 9/10

Solid PR with good attention to edge cases. The only minor observation (not blocking) is that the WebSourcesPill click-outside handler could potentially be replaced with a Radix/headless popover for consistency, but the current implementation is correct.

@MaheshtheDev MaheshtheDev force-pushed the mahesh/nova-chat-polish branch from f27199b to d13c493 Compare June 8, 2026 06:03

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview: Adds Grok 4.3 as the default model, improves web sources UX with citation hover cards and a collapsible sources pill, fixes mobile layout/navigation, and addresses several bugs including tool_use/tool_result mismatches and a11y issues.

Issues found: None — this looks good to ship.

Key changes reviewed:

  • Tool parts sanitization (index.tsx:356-363): Correctly strips tool parts before sending to backend, fixing the tool_use/tool_result mismatch on follow-up messages.
  • Text run merging (agent-message.tsx:583-599): Properly coalesces text parts split by source-url citations to prevent broken markdown rendering.
  • Citation hover cards (agent-message.tsx:72-120): Clean implementation with proper URL parsing and graceful fallbacks.
  • A11y fix (select-spaces-modal.tsx): Added missing DialogTitle — good catch.
  • Error message extraction (use-document-mutations.ts): The new fetchErrorMessage helper handles multiple error formats cleanly.

Score: 9/10

Solid PR with good attention to edge cases. The only minor observation (not blocking) is that the WebSourcesPill click-outside handler could potentially be replaced with a Radix/headless popover for consistency, but the current implementation is correct.

MaheshtheDev commented Jun 8, 2026

Copy link
Copy Markdown
Member Author

How to use the Graphite Merge Queue

Add the label Main to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@MaheshtheDev MaheshtheDev changed the title Grok 4.3, web sources UX, and mobile polish (stacked on #1004) Grok 4.3, web sources UX, and mobile polish Jun 8, 2026
@graphite-app graphite-app Bot changed the base branch from ishaan/attach to graphite-base/1064 June 8, 2026 06:18
@graphite-app graphite-app Bot force-pushed the graphite-base/1064 branch from 31550ec to 7095548 Compare June 8, 2026 06:19
@graphite-app graphite-app Bot force-pushed the mahesh/nova-chat-polish branch from d13c493 to 57bb732 Compare June 8, 2026 06:19
@graphite-app graphite-app Bot changed the base branch from graphite-base/1064 to main June 8, 2026 06:20
Stacked on the Nova chat attachments PR (#1004): adds Grok 4.3 (default), reworks the composer toolbar + web-source citations, and overhauls the mobile chat experience (sticky nav, pinned composer, back button). Plus a11y, delete-toast, and markdown fixes.
@graphite-app graphite-app Bot force-pushed the mahesh/nova-chat-polish branch from 57bb732 to 023ea8e Compare June 8, 2026 06:20
@ishaanxgupta ishaanxgupta merged commit 7ec3e57 into main Jun 8, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants