refactor(planet): migrate planetThemes.css hardcoded colours to CSS tokens#7430
Open
adarsh-yadav1 wants to merge 1 commit into
Open
refactor(planet): migrate planetThemes.css hardcoded colours to CSS tokens#7430adarsh-yadav1 wants to merge 1 commit into
adarsh-yadav1 wants to merge 1 commit into
Conversation
Contributor
|
🧪 Jest Test Results ❌ Some Jest tests failed. Please check the logs and fix the issues before merging. Coverage: Statements: 48.11% | Branches: 39.52% | Functions: 52.84% | Lines: 48.52% Note: These failures may be introduced by this PR or may already exist in the master branch. Failed Tests: |
Author
|
@walterbender @sum2it This migrates all hardcoded colours in |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Category
Summary
Replaces all hardcoded hex colour values in planet/css/planetThemes.css
with CSS custom property tokens from css/tokens.css, and wires
css/tokens.css into planet/index.html.
What Changed
planet/css/planetThemes.css— 163 hardcoded hex values replacedwith token references across dark and high-contrast themes
planet/index.html— added import of ../css/tokens.cssBefore vs After
#303030var(--color-background)#e0e0e0var(--color-text-primary)#444444var(--color-border)#424242var(--color-surface-raised)#000080var(--color-background)#ffff00var(--color-text-primary)#ffff00var(--color-heading)Screenshots
Light theme
Dark theme
High contrast theme
Test Plan
Note
This PR depends on css/tokens.css being present, introduced in
PR #7366 . The import path ../css/tokens.css
is correct for the merged state.
Why
Part of #6606
Directly satisfies acceptance criterion 6 from the DMP 2026 project
ticket: "The Planet page uses the same token system as the main app."
All colour decisions in the Planet page now cascade from the same
tokens defined in css/tokens.css, enabling instant theme switching
without page reload.