fix: show unfixable rubocop offenses on format failure#1897
Open
jar-stripe wants to merge 1 commit into
Open
Conversation
Replace `-o /dev/null` with `--display-only-fail-level-offenses`. This suppresses the ~1.5MB report of corrected offenses (which would overflow the caller's buffer) while still showing uncorrectable offenses directly. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Committed-By-Agent: claude
jar-stripe
force-pushed
the
jar/format-diagnostic
branch
from
19b603f to
7a93f78
Compare
jar-stripe
requested review from
Copilot and
justiny-stripe
and removed request for
a team
There was a problem hiding this comment.
Pull request overview
Improves diagnostics from just format when RuboCop autocorrect can’t fix everything, aiming to surface the remaining unfixable offenses instead of failing with little/no output.
Changes:
- Updates the
formatrecipe to run RuboCop autocorrect with a flag intended to suppress non-failing output and show only fail-level offenses.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
When codegen runs
just formatand rubocop can't autocorrect everything (e.g. a string literal exceeds the 120-char line limit), the format step fails with no useful output. This is because rubocop's autocorrect report is suppressed with-o /dev/nullto avoid crashing sdk-codegen with its overwhelming output.What?
See Also