Add Time Zone Select by tvdeyen · Pull Request #6437 · solidusio/solidus

tvdeyen · 2026-04-15T20:42:17Z

Summary

Adding a timezone select into the various admin/backend navigations we have. Allows for users to see dates in the admin in the selected timezone. If the current solidus user record has a preferred timezone this is used instead. The resolved timezone is stored in the users session.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

I agree that my PR will be published under the same license as Solidus.
I have written a thorough PR description.
I have kept my commits small and atomic.
I have localized any and all user-facing strings that I added to the source code.
I have used clear, explanatory commit messages.

The following are not always needed:

📖 I have updated the README to account for my changes.
📑 I have documented new code with YARD.
🛣️ I have opened a PR to update the guides.
✅ I have added automated tests to cover my changes.
📸 I have attached screenshots to demo visual changes.

codecov · 2026-04-15T20:45:09Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.70%. Comparing base (8d781ac) to head (b703657).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6437      +/-   ##
==========================================
+ Coverage   89.68%   89.70%   +0.01%     
==========================================
  Files         993      994       +1     
  Lines       20863    20886      +23     
==========================================
+ Hits        18712    18735      +23     
  Misses       2151     2151

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

By including this module into a controller it will run all controller actions within the defined timezone. The timezone is taken from the params, the session, user preference (if existing), or the default timezone of the app. The resolved timezone is then stored in the session for future reference.

Use the `Spree::Core::ControllerHelpers::Timezone` module to wrap all admin actions inside the selected timezone.

Use the `Spree::Core::ControllerHelpers::Timezone` module to wrap all admin actions inside the selected timezone. Signed-off-by: Thomas von Deyen <vondeyen@blish.cloud>

Spans do not self close and this actually has a closing tag anyway. Signed-off-by: Thomas von Deyen <vondeyen@blish.cloud>

Signed-off-by: Thomas von Deyen <vondeyen@blish.cloud>

If the user has a timezone column we show a select to let admins set the preferred time zone of the user.

houndci-bot · 2026-06-10T15:05:10Z

+    it "sets timezone by param" do
+      get :index, params: {solidus_timezone: "Hawaii"}
+      expect(session).to have_key(:solidus_timezone)
+      expect(session[:solidus_timezone]).to eq("Hawaii")


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2026-06-10T15:05:10Z

    end
+
+    it "sets timezone by param" do
+      get :index, params: {solidus_timezone: "Hawaii"}


Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.

houndci-bot · 2026-06-10T15:05:10Z

      expect(response.code).to eq "200"
    end
+
+    it "sets timezone by param" do


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2026-06-10T15:05:10Z

  end

-  context "successful request" do
+  context "authorized request" do


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2026-06-10T15:05:10Z

    let(:sign_in_date) { DateTime.now }

    before do
+      allow_any_instance_of(Spree.user_class).to receive(:try).with(:timezone) { nil }


Metrics/LineLength: Line is too long. [86/80]

houndci-bot · 2026-06-10T15:05:10Z

        let!(:user) { create :user }

-        before { expect(controller).to receive(:spree_current_user).and_return(user) }
+        before { expect(controller).to receive(:spree_current_user).twice.and_return(user) }


Metrics/LineLength: Line is too long. [92/80]

houndci-bot · 2026-06-10T15:05:10Z

+
+        # Checks if we need to change the timezone or not.
+        def timezone_change_needed?
+          params[:solidus_timezone].present? || session[:solidus_timezone].blank?


Metrics/LineLength: Line is too long. [81/80]

houndci-bot · 2026-06-10T15:05:10Z

+            resolved_timezone || Time.zone.name
+          else
+            session[:solidus_timezone]
+          end


Layout/EndAlignment: end at 26, 10 is not aligned with if at 22, 21.

houndci-bot · 2026-06-10T15:05:10Z

+        def set_timezone(&action)
+          timezone = if timezone_change_needed?
+            resolved_timezone || Time.zone.name
+          else


Layout/ElseAlignment: Align else with if.

houndci-bot · 2026-06-10T15:05:10Z

+        #
+        def set_timezone(&action)
+          timezone = if timezone_change_needed?
+            resolved_timezone || Time.zone.name


Layout/IndentationWidth: Use 2 (not -9) spaces for indentation.

tvdeyen added the type:enhancement Proposed or newly added feature label Apr 15, 2026

tvdeyen self-assigned this Apr 15, 2026

github-actions Bot added changelog:solidus_backend Changes to the solidus_backend gem changelog:solidus_core Changes to the solidus_core gem changelog:solidus_admin labels Apr 15, 2026

github-project-automation Bot added this to Solidus Admin Apr 15, 2026

tvdeyen force-pushed the timezone-select branch 4 times, most recently from 899d5a5 to c8011a0 Compare April 23, 2026 08:11

tvdeyen marked this pull request as ready for review April 23, 2026 08:12

tvdeyen requested a review from a team as a code owner April 23, 2026 08:12

tvdeyen removed their assignment Apr 24, 2026

tvdeyen force-pushed the timezone-select branch from c8011a0 to def12cd Compare April 24, 2026 07:42

jarednorman approved these changes Apr 27, 2026

View reviewed changes

tvdeyen force-pushed the timezone-select branch from def12cd to 2378c1d Compare May 13, 2026 15:15

tvdeyen modified the milestone: 4.8 May 13, 2026

github-project-automation Bot added this to Solidus Public Roadmap May 13, 2026

tvdeyen added 8 commits June 10, 2026 17:04

feat(backend): Handle timezone changes

cebd0b9

Use the `Spree::Core::ControllerHelpers::Timezone` module to wrap all admin actions inside the selected timezone.

feat(admin): Handle timezone changes

6b40357

Use the `Spree::Core::ControllerHelpers::Timezone` module to wrap all admin actions inside the selected timezone. Signed-off-by: Thomas von Deyen <vondeyen@blish.cloud>

fix(admin navigation): Remove invalid html closing tag

d7951f8

Spans do not self close and this actually has a closing tag anyway. Signed-off-by: Thomas von Deyen <vondeyen@blish.cloud>

feat(admin): Add timezone select

a1e4b82

Signed-off-by: Thomas von Deyen <vondeyen@blish.cloud>

feat(backend): Add timezone select

dd45a71

Signed-off-by: Thomas von Deyen <vondeyen@blish.cloud>

feat(backend): Add timezone select to users form

7bc3146

If the user has a timezone column we show a select to let admins set the preferred time zone of the user.

feat(admin): Add timezone select to users form

b703657

If the user has a timezone column we show a select to let admins set the preferred time zone of the user.

tvdeyen force-pushed the timezone-select branch from 2378c1d to b703657 Compare June 10, 2026 15:04

houndci-bot reviewed Jun 10, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add Time Zone Select#6437

Add Time Zone Select#6437
tvdeyen wants to merge 8 commits into
solidusio:mainfrom
blish:timezone-select

tvdeyen commented Apr 15, 2026 •

edited

Loading

Uh oh!

codecov Bot commented Apr 15, 2026 •

edited

Loading

Uh oh!

houndci-bot Jun 10, 2026

Uh oh!

houndci-bot Jun 10, 2026

Uh oh!

houndci-bot Jun 10, 2026

Uh oh!

houndci-bot Jun 10, 2026

Uh oh!

houndci-bot Jun 10, 2026

Uh oh!

houndci-bot Jun 10, 2026

Uh oh!

houndci-bot Jun 10, 2026

Uh oh!

houndci-bot Jun 10, 2026

Uh oh!

houndci-bot Jun 10, 2026

Uh oh!

houndci-bot Jun 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

tvdeyen commented Apr 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

Uh oh!

codecov Bot commented Apr 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

tvdeyen commented Apr 15, 2026 •

edited

Loading

codecov Bot commented Apr 15, 2026 •

edited

Loading