fix: add repository field to published packages for provenance validation#2158
Merged
Conversation
…tion npm trusted publishing generates provenance attestations and requires package.json "repository.url" to match the source repo. Both packages were missing the field, failing publish with E422. Co-authored-by: Cursor <cursoragent@cursor.com>
|
✅ Deploy Preview for solid-start-landing-page ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #2157. The release got past authentication (OIDC worked, provenance was signed) but npm rejected both packages with E422:
Trusted publishing generates provenance attestations, and npm validates that the published
package.jsonrepository.urlmatches the repo in the attestation. Neither@solidjs/startnor@solidjs/vite-plugin-nitro-2had arepositoryfield. This adds it (withdirectoryfor the monorepo path).No changeset on purpose: the pending
2.0.0-alpha.3/0.3.0are versioned but unpublished — merging with no changesets makes the action retry publishing them directly.Test plan
Made with Cursor