Reduced Scala.js bundle size for scala-java-time only#4500
Merged
Conversation
Contributor
Author
|
@adamw as requested |
Member
|
Thank you! |
Contributor
Author
|
damn, looks like I must've missed something, this didn't have the same bundle-size drop as the full version did; I'll have to take another look through. scala-java-time is still being retained by the results of this PR somehow. |
adamw
pushed a commit
that referenced
this pull request
Apr 12, 2025
`CookieWithMeta` also pulls in `scala-java-time`, so these two `Codec`s have also been made lazy as per #4500. I've confirmed this is the minimal set to avoid the dependency entirely, saving a full 1.12MB of bundle size (a further ~0.4MB can be saved on other codecs)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up from #4461, but only focusing on the scala-java-time aspect.