fix(android, ios): Link copy-pasting inconsistencies#640
Open
hejsztynx wants to merge 8 commits into
Open
Conversation
hejsztynx
force-pushed
the
@ksienkiewicz/fix-link-copy-pasting
branch
from
2accb4b to
056004f
Compare
kacperzolkiewski
left a comment
kacperzolkiewski
left a comment
Collaborator
There was a problem hiding this comment.
copying pasting an autolink resulted in creating a manual link unnecessarily
Screen.Recording.2026-06-17.at.15.27.31.mov
It still recognizes it as a link on Android when we paste it directly next to another letter, until we type something.
Comment on lines
+365
to
+369
| LinkRegexConfig *linkRegexConfig = [config linkRegexConfig]; | ||
| if (linkRegexConfig == nullptr || linkRegexConfig.isDisabled) { | ||
| return NO; | ||
| } | ||
| NSRange range = NSMakeRange(0, url.length); |
Co-authored-by: Kacper Żółkiewski <74975508+kacperzolkiewski@users.noreply.github.com>
hejsztynx
force-pushed
the
@ksienkiewicz/fix-link-copy-pasting
branch
from
aff5a27 to
431f1c7
Compare
Collaborator
Author
fixed, the same issue happened when we would paste text inside a finalized mention - the fix was shared |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
There were some inconsistencies when copy-pasting created links
iOS:
href == textValue, but thehrefdoes not match the givenlinkRegex, it gets marked as an autolink, which immediately removes the link, as the regex match failsAndroid:
Videos
The said iOS bug
Screen.Recording.2026-06-15.at.18.34.30.mov
Compatibility
Checklist