Skip to content

fix(iOS): rendering numeric entities#638

Open
kacperzolkiewski wants to merge 5 commits into
mainfrom
@kacperzolkiewski/fix-numeric
Open

fix(iOS): rendering numeric entities#638
kacperzolkiewski wants to merge 5 commits into
mainfrom
@kacperzolkiewski/fix-numeric

Conversation

@kacperzolkiewski

@kacperzolkiewski kacperzolkiewski commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator

Summary

Fixes: #636

This PR adds support for numeric character references (both decimal and hexadecimal), for example: 用 and 用.

Test Plan

Run reproduction steps from issue: #636
Issue should be resolved.

Screenshots / Videos

Screen.Recording.2026-06-15.at.09.54.18.mov

Compatibility

OS Implemented
iOS
Android

Checklist

  • E2E tests are passing
  • Required E2E tests have been added (if applicable)

Copilot AI review requested due to automatic review settings June 15, 2026 07:57

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds iOS-side decoding for numeric HTML character references so HTML persisted from Android (which emits non‑ASCII as &#NNNN; / &#xHHHH;) renders as proper Unicode text when loaded into the iOS editor.

Changes:

  • Decode decimal numeric character references of the form &#NNNN;.
  • Decode hexadecimal numeric character references of the form &#xHHHH; into UTF‑16 (including surrogate pairs for code points > 0xFFFF).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread ios/extensions/StringExtension.mm
Comment thread ios/extensions/StringExtension.mm Outdated
kacperzolkiewski and others added 3 commits June 15, 2026 10:02
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

Comment thread ios/extensions/StringExtension.mm
Comment thread ios/extensions/StringExtension.mm Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

iOS setValue renders numeric HTML entities emitted by Android getHTML as literal text

2 participants