Skip to content

Delete nftx EA#5089

Merged
dskloetc merged 4 commits into
mainfrom
kloet/rm-nftx
Jun 17, 2026
Merged

Delete nftx EA#5089
dskloetc merged 4 commits into
mainfrom
kloet/rm-nftx

Conversation

@dskloetc

Copy link
Copy Markdown
Contributor

Description

We have many EAs which are not referenced from RDD at all and are also not referenced by other EAs.

Some of these might still be used in other ways, as discussed here.

But @thomjg confirmed that nftx is one of the EAs that is not used anywhere.

Changes

As separate commits:

  1. git rm -r packages/sources/nftx
  2. git grep -liE nftx and made manual changes in some of those files.
  3. yarn

Steps to Test

N/A

Quality Assurance

  • If a new adapter was made, or an existing one was modified so that its environment variables have changed, update the relevant infra-k8s configuration file.
  • If a new adapter was made, or an existing one was modified so that its environment variables have changed, update the relevant adapter-secrets configuration file or update the soak testing blacklist.
  • If a new adapter was made, or a new endpoint was added, update the test-payload.json file with relevant requests.
  • The branch naming follows git flow (feature/x, chore/x, release/x, hotfix/x, fix/x) or is created from Jira.
  • This is related to a maximum of one Jira story or GitHub issue.
  • Types are safe (avoid TypeScript/TSLint features like any and disable, instead use more specific types).
  • All code changes have 100% unit and integration test coverage. If testing is not applicable or too difficult to justify doing, the reasoning should be documented explicitly in the PR.

@changeset-bot

changeset-bot Bot commented Jun 17, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 35f9b17

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dskloetc dskloetc enabled auto-merge (squash) June 17, 2026 12:00
@dskloetc dskloetc merged commit 88da3b0 into main Jun 17, 2026
21 of 22 checks passed
@dskloetc dskloetc deleted the kloet/rm-nftx branch June 17, 2026 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants