Fix hex color component parsing#471
Open
haaaaaaarshs wants to merge 1 commit into
Open
Conversation
|
Thank you for your pull request and welcome to the Skip community. We require contributors to sign our contributor license agreement (CLA), and we don't seem to have the user(s) @haaaaaaarshs on file. In order for us to review and merge your code, for each noted user please add your GitHub username to Skip's .clabot file |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to the Skip project! Please review the contribution guide at https://skip.dev/docs/contributing/ for advice and guidance on making high-quality PRs.
This PR fixes custom
.colorsetparsing when asset catalog component values are stored as hexadecimal strings such as"0x94"or"0XFF".The existing parser attempted to parse every color component with
Double(...), which works for normalized decimal strings like"1.000"but fails for hex component strings. This change adds a small parsing path for0x/0Xvalues and converts those 8-bit channel values into normalizedDoublevalues between 0 and 1, while keeping the existing decimal parsing behavior unchanged.Closes #146
Skip Pull Request Checklist:
swift testAI was used to review the implementation for correctness and scope before submission. I manually reviewed the code changes, checked that the implementation specifically handles
0x/0Xhex component strings, preserved the existing decimal parsing behavior, and tested the project locally withswift test.