Handle ignored inserts with explicit primary keys#756
Open
KairosOps wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes the
IndexErrorfrom #554 when a single-rowinsert(..., pk=..., ignore=True)is ignored after another table has advanced SQLite's connection-levellastrowid.In that case
cursor.lastrowidcan point at a rowid from a different table, so looking up that rowid in the current table can return no rows. The insert already had an explicit primary key, so when SQLite reportsrowcount == 0for the ignored insert this now keepslast_pkbased on the input record instead of trying to resolve it through the stale rowid.Checks
python -m pytest tests/test_create.py::test_insert_ignore tests/test_create.py::test_insert_ignore_with_pk_after_other_table_insert -qpython -m pytest tests/test_create.py -qpython -m py_compile sqlite_utils/db.py tests/test_create.pygit diff --checkpython -m black --fast --check sqlite_utils/db.py tests/test_create.pyRefs #554
📚 Documentation preview 📚: https://sqlite-utils--756.org.readthedocs.build/en/756/