Skip to content

feat: migrate from Newtonsoft.Json to System.Text.Json#1209

Open
paviad wants to merge 2 commits into
sendgrid:mainfrom
paviad:stj
Open

feat: migrate from Newtonsoft.Json to System.Text.Json#1209
paviad wants to merge 2 commits into
sendgrid:mainfrom
paviad:stj

Conversation

@paviad

@paviad paviad commented Jul 23, 2024

Copy link
Copy Markdown

Fixes

Closes #1208

Possibly impacts #985 (which is a duplicate of a #1050 which is a request to support System.Text.Json)

Description

This PR includes conditional compilation checks to use System.Text.Json instead of Newtonsoft.Json everywhere when targeting .NET Standard 2.0

The tests projects have been duplicated and modified to test both the old and the new versions.

All tests pass (except integration tests, which I could not get to work despite having configured a valid SendGrid API Key) - As a consequence of this, all integration tests are marked for skipping using [Fact(Skip = ... and [Theory(Skip = ...

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

@paviad paviad changed the title feat: migrate from newtonsoft to system.text.json feat: migrate from Newtonsoft.Json to System.Text.Json Jul 23, 2024
@geferon

geferon commented Sep 27, 2024

Copy link
Copy Markdown

Any progress on this?

@p-gaspar

p-gaspar commented Apr 23, 2025

Copy link
Copy Markdown

I would also like to know if there's any progress on this. It's already been nearly a year since this PR was requested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove dependency on Newtonsoft.Json and migrate to System.Text.Json for modern projects

3 participants