Skip to content

[UIK-5280][outside-click] fixed check node.contains, because in d3-chart node can be not HTMLElement#3011

Merged
Valeria-Zimnitskaya merged 3 commits into
release/v17from
UIK-5280/d3-chart-popper-click-error
Jun 18, 2026
Merged

[UIK-5280][outside-click] fixed check node.contains, because in d3-chart node can be not HTMLElement#3011
Valeria-Zimnitskaya merged 3 commits into
release/v17from
UIK-5280/d3-chart-popper-click-error

Conversation

@ilyabrower

Copy link
Copy Markdown
Contributor

Changelog

@semcore/outside-click

Fixed

  • Checking node.contains because in d3-chart a node may not be an HTMLElement.

Motivation and Context

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Nice improve.

Checklist:

  • I have updated the documentation accordingly.
  • I have added new tests on added of fixed functionality.

@Valeria-Zimnitskaya Valeria-Zimnitskaya self-requested a review June 18, 2026 13:24
@Valeria-Zimnitskaya Valeria-Zimnitskaya merged commit 0c49502 into release/v17 Jun 18, 2026
14 checks passed
@Valeria-Zimnitskaya Valeria-Zimnitskaya deleted the UIK-5280/d3-chart-popper-click-error branch June 18, 2026 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants