Skip to content

[UIK-5196][pagination] rewrite component to TS#3002

Merged
Valeria-Zimnitskaya merged 6 commits into
release/v17from
UIK-5196/rewrite-component-to-ts
Jun 18, 2026
Merged

[UIK-5196][pagination] rewrite component to TS#3002
Valeria-Zimnitskaya merged 6 commits into
release/v17from
UIK-5196/rewrite-component-to-ts

Conversation

@slizhevskyv-semrush

Copy link
Copy Markdown
Contributor

Changelog

@semcore/pagination

Fixed

  • Rewrite component to TS. Deprecate atomic types. Atomic types are part of NSPagination namespace.

Motivation and Context

Rewrite component to TS. Deprecated atomic types in favor namespaces. Nothing changed in how component works.

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Nice improve.

Checklist:

  • I have updated the documentation accordingly.
  • I have added new tests on added of fixed functionality.

@slizhevskyv-semrush slizhevskyv-semrush requested review from Valeria-Zimnitskaya and ilyabrower and removed request for ilyabrower June 15, 2026 10:55
Comment thread semcore/pagination/src/Pagination.tsx
&[size='l'] {
font-size: var(--intergalactic-fs-300, 16px);
line-height: var(--intergalactic-lh-300, 150%);
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should remove all this logic, and just set size to the STotalPages in render

@slizhevskyv-semrush slizhevskyv-semrush Jun 17, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to leave this logic, since the sizes could be different between internal logic and the props passed down to the component :) (since it's a Root component)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

especially... just remove this styles)

and also color, I think

@Valeria-Zimnitskaya Valeria-Zimnitskaya merged commit 1637fd0 into release/v17 Jun 18, 2026
14 checks passed
@Valeria-Zimnitskaya Valeria-Zimnitskaya deleted the UIK-5196/rewrite-component-to-ts branch June 18, 2026 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants