fix(secrets): restore DeleteSecret for synchronized keys on writable storage#3859
Draft
cursor[bot] wants to merge 1 commit into
Draft
fix(secrets): restore DeleteSecret for synchronized keys on writable storage#3859cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
…rage Commit 757e9e9 merged key.Synchronized into the read-only branch, so deleting a synchronized access key skipped backend secret removal whenever Synchronized was true—even for writable vaults—orphaning credentials. Restore the pre-refactor rules: block delete only for synchronized keys on read-only storage; always invoke DeleteSecret when the storage is writable. Add unit tests for writable+synchronized, read-only+non-sync, and read-only+synchronized cases. Co-authored-by: Denis Gukov <fiftin@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a regression from
757e9e9c(vault sync refactor) inAccessKeyServiceImpl.Delete.Bug and impact
When deleting an access key backed by a writable external secret store (Vault, AWS SM, etc.), if the key was marked synchronized, the service skipped
DeleteSecretentirely. The Semaphore DB row was still removed, so the credential could remain in the external vault as an orphan—a correctness and hygiene issue (and a potential security concern if operators assume deletion removes the secret everywhere).Root cause
The refactor combined
storage.ReadOnlyandkey.Synchronizedinto a single branch that always skippedDeleteSecret. The intended behavior (from the earlier read-only fix) is:Fix
Restore the previous branching: only skip
DeleteSecretwhen the storage is read-only; keep the user-facing error for synchronized keys on read-only storage.Validation
go test ./services/server/ -count=1DeleteSecret), read-only+non-sync (expects zero), read-only+synchronized (expects error and no DB delete).