Skip to content

ci: remove NPM and Yarn support #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cxymds merged 2 commits into from
Jun 4, 2026
Merged

ci: remove NPM and Yarn support #125

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed73b37
ci: remove NPM and Yarn support
nakrovati May 30, 2026
174b0ab
Merge branch 'main' into ci/remove-yarn-npm-support
cxymds Jun 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 12 additions & 24 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,39 +30,24 @@ jobs:
steps:
- name: Checkout
uses: actions/checkout@v6
- name: Detect package manager
id: detect-package-manager
run: |
if [ -f "${{ github.workspace }}/pnpm-lock.yaml" ]; then
echo "manager=pnpm" >> $GITHUB_OUTPUT
echo "command=install --frozen-lockfile" >> $GITHUB_OUTPUT
exit 0
elif [ -f "${{ github.workspace }}/yarn.lock" ]; then
echo "manager=yarn" >> $GITHUB_OUTPUT
echo "command=install" >> $GITHUB_OUTPUT
exit 0
elif [ -f "${{ github.workspace }}/package-lock.json" ]; then
echo "manager=npm" >> $GITHUB_OUTPUT
echo "command=ci" >> $GITHUB_OUTPUT
exit 0
else
echo "Unable to determine package manager"
exit 1
fi
- name: Setup pnpm
if: steps.detect-package-manager.outputs.manager == 'pnpm'

- name: Setup PNPM
uses: pnpm/action-setup@v6
with:
version: ${{ env.PNPM_VERSION }}
cache: true

- name: Setup Node
uses: actions/setup-node@v6
with:
node-version: ${{ env.NODE_VERSION }}
cache: ${{ steps.detect-package-manager.outputs.manager }}

- name: Install dependencies
run: ${{ steps.detect-package-manager.outputs.manager }} ${{ steps.detect-package-manager.outputs.command }}
run: pnpm ci

- name: Build Next.js
run: ${{ steps.detect-package-manager.outputs.manager }} run build
run: pnpm build

- name: Zip files
run: |
set -euo pipefail
Expand All @@ -79,10 +64,12 @@ jobs:
zip -r ../artifacts/${{ github.event.release.tag_name }}/rustfs-console-${{ github.event.release.tag_name }}.zip .
)
fi

- uses: actions/upload-artifact@v7
name: Upload artifacts
with:
path: ./artifacts/rustfs-console-latest.zip

- name: Upload to Bucket for `latest`
uses: JohnGuan/oss-upload-action@main
with:
Expand All @@ -92,6 +79,7 @@ jobs:
bucket: rustfs-artifacts
assets: |
./artifacts/**:/artifacts/console/

- name: Upload release asset `versioned`
if: ${{ github.event_name == 'release' }}
uses: softprops/action-gh-release@v3
Expand Down
120 changes: 34 additions & 86 deletions .github/workflows/dependencies.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,46 +33,27 @@ jobs:
- name: 📥 Checkout code
uses: actions/checkout@v6

- name: Detect package manager
id: detect-package-manager
run: |
if [ -f "${{ github.workspace }}/pnpm-lock.yaml" ]; then
echo "manager=pnpm" >> $GITHUB_OUTPUT
echo "command=install --frozen-lockfile" >> $GITHUB_OUTPUT
exit 0
elif [ -f "${{ github.workspace }}/yarn.lock" ]; then
echo "manager=yarn" >> $GITHUB_OUTPUT
echo "command=install" >> $GITHUB_OUTPUT
exit 0
elif [ -f "${{ github.workspace }}/package-lock.json" ]; then
echo "manager=npm" >> $GITHUB_OUTPUT
echo "command=ci" >> $GITHUB_OUTPUT
exit 0
else
echo "Unable to determine package manager"
exit 1
fi
- name: Setup pnpm
if: steps.detect-package-manager.outputs.manager == 'pnpm'
- name: Setup PNPM
uses: pnpm/action-setup@v6
with:
version: ${{ env.PNPM_VERSION }}
cache: true

- name: 📦 Setup Node.js
uses: actions/setup-node@v6
with:
node-version: ${{ env.NODE_VERSION }}
cache: ${{ steps.detect-package-manager.outputs.manager }}

- name: 📥 Install dependencies
run: ${{ steps.detect-package-manager.outputs.manager }} ${{ steps.detect-package-manager.outputs.command }}
run: pnpm ci

- name: 🔒 Run security audit
run: |
echo "## 🔒 Security Audit Report" >> $GITHUB_STEP_SUMMARY
echo "" >> $GITHUB_STEP_SUMMARY

# 运行安全审计
if ${{ steps.detect-package-manager.outputs.manager }} audit --json > audit-report.json 2>/dev/null; then
if pnpm audit --json > audit-report.json 2>/dev/null; then
# 解析审计结果
vulnerabilities=$(node -e "
const audit = require('./audit-report.json');
Expand Down Expand Up @@ -102,7 +83,7 @@ jobs:
echo "" >> $GITHUB_STEP_SUMMARY
echo "⚠️ **Action Required**: $total_vulns security vulnerabilities found!" >> $GITHUB_STEP_SUMMARY
echo "" >> $GITHUB_STEP_SUMMARY
echo "Run \`${{ steps.detect-package-manager.outputs.manager }} audit fix\` to automatically fix vulnerabilities." >> $GITHUB_STEP_SUMMARY
echo "Run \`pnpm audit --fix\` to automatically fix vulnerabilities." >> $GITHUB_STEP_SUMMARY

# 如果有高危或严重漏洞，创建 issue
critical=$(echo $vulnerabilities | jq -r '.critical')
Expand Down Expand Up @@ -179,38 +160,19 @@ jobs:
- name: 📥 Checkout code
uses: actions/checkout@v6

- name: Detect package manager
id: detect-package-manager
run: |
if [ -f "${{ github.workspace }}/pnpm-lock.yaml" ]; then
echo "manager=pnpm" >> $GITHUB_OUTPUT
echo "command=install --frozen-lockfile" >> $GITHUB_OUTPUT
exit 0
elif [ -f "${{ github.workspace }}/yarn.lock" ]; then
echo "manager=yarn" >> $GITHUB_OUTPUT
echo "command=install" >> $GITHUB_OUTPUT
exit 0
elif [ -f "${{ github.workspace }}/package-lock.json" ]; then
echo "manager=npm" >> $GITHUB_OUTPUT
echo "command=ci" >> $GITHUB_OUTPUT
exit 0
else
echo "Unable to determine package manager"
exit 1
fi
- name: Setup pnpm
if: steps.detect-package-manager.outputs.manager == 'pnpm'
- name: Setup PNPM
uses: pnpm/action-setup@v6
with:
version: ${{ env.PNPM_VERSION }}
cache: true

- name: 📦 Setup Node.js
uses: actions/setup-node@v6
with:
node-version: ${{ env.NODE_VERSION }}
cache: ${{ steps.detect-package-manager.outputs.manager }}

- name: 📥 Install dependencies
run: ${{ steps.detect-package-manager.outputs.manager }} ${{ steps.detect-package-manager.outputs.command }}
run: pnpm ci

- name: 📋 Check for outdated packages
id: check
Expand All @@ -219,7 +181,7 @@ jobs:
echo "" >> $GITHUB_STEP_SUMMARY

# 检查过期的包
if ${{ steps.detect-package-manager.outputs.manager }} outdated --json > outdated.json 2>/dev/null; then
if pnpm outdated --json > outdated.json 2>/dev/null; then
if [ -s outdated.json ]; then
echo "has-updates=true" >> $GITHUB_OUTPUT

Expand Down Expand Up @@ -279,14 +241,19 @@ jobs:
with:
token: ${{ secrets.GITHUB_TOKEN }}

- name: Setup PNPM
uses: pnpm/action-setup@v6
with:
version: ${{ env.PNPM_VERSION }}
cache: true

- name: 📦 Setup Node.js
uses: actions/setup-node@v6
with:
node-version: ${{ env.NODE_VERSION }}
cache: "npm"

- name: 📥 Install dependencies
run: npm ci
run: pnpm ci

- name: 🔄 Update dependencies
run: |
Expand All @@ -298,22 +265,22 @@ jobs:
case $update_type in
"patch")
echo "Updating patch versions..." >> $GITHUB_STEP_SUMMARY
${{ steps.detect-package-manager.outputs.manager }} update
pnpm update
;;
"minor")
echo "Updating minor versions..." >> $GITHUB_STEP_SUMMARY
npx npm-check-updates -u --target minor
${{ steps.detect-package-manager.outputs.manager }} install
pnpm dlx npm-check-updates -u -p pnpm --target minor
pnpm install
;;
"major")
echo "Updating major versions..." >> $GITHUB_STEP_SUMMARY
npx npm-check-updates -u --target major
${{ steps.detect-package-manager.outputs.manager }} install
pnpm dlx npm-check-updates -u -p pnpm --target major
pnpm install
;;
"all")
echo "Updating all versions..." >> $GITHUB_STEP_SUMMARY
npx npm-check-updates -u
${{ steps.detect-package-manager.outputs.manager }} install
pnpm dlx npm-check-updates -u -p pnpm
pnpm install
;;
esac

Expand All @@ -323,10 +290,10 @@ jobs:
echo "" >> $GITHUB_STEP_SUMMARY

# 安装测试依赖
${{ steps.detect-package-manager.outputs.manager }} add -D vitest jsdom @vitest/ui c8
pnpm add -D vitest jsdom @vitest/ui c8

# 运行测试
if npx vitest run tests/utils/config-helpers*.test.ts --reporter=verbose; then
if pnpm vitest run tests/utils/config-helpers*.test.ts --reporter=verbose; then
echo "✅ All tests passed with updated dependencies!" >> $GITHUB_STEP_SUMMARY
echo "test_status=passed" >> $GITHUB_ENV
else
Expand All @@ -349,7 +316,7 @@ jobs:
done

# 检查 package.json 的变更
if git diff --name-only | grep -q "package.json\|pnpm-lock.yaml\|package-lock.json\|yarn.lock"; then
if git diff --name-only | grep -q "package.json\|pnpm-lock.yaml"; then
echo "" >> $GITHUB_STEP_SUMMARY
echo "### Package Changes:" >> $GITHUB_STEP_SUMMARY
echo "\`\`\`diff" >> $GITHUB_STEP_SUMMARY
Expand Down Expand Up @@ -445,47 +412,28 @@ jobs:
- name: 📥 Checkout code
uses: actions/checkout@v6

- name: Detect package manager
id: detect-package-manager
run: |
if [ -f "${{ github.workspace }}/pnpm-lock.yaml" ]; then
echo "manager=pnpm" >> $GITHUB_OUTPUT
echo "command=install --frozen-lockfile" >> $GITHUB_OUTPUT
exit 0
elif [ -f "${{ github.workspace }}/yarn.lock" ]; then
echo "manager=yarn" >> $GITHUB_OUTPUT
echo "command=install" >> $GITHUB_OUTPUT
exit 0
elif [ -f "${{ github.workspace }}/package-lock.json" ]; then
echo "manager=npm" >> $GITHUB_OUTPUT
echo "command=ci" >> $GITHUB_OUTPUT
exit 0
else
echo "Unable to determine package manager"
exit 1
fi
- name: Setup pnpm
if: steps.detect-package-manager.outputs.manager == 'pnpm'
- name: Setup PNPM
uses: pnpm/action-setup@v6
with:
version: ${{ env.PNPM_VERSION }}
cache: true

- name: 📦 Setup Node.js
uses: actions/setup-node@v6
with:
node-version: ${{ env.NODE_VERSION }}
cache: ${{ steps.detect-package-manager.outputs.manager }}

- name: 📥 Install dependencies
run: ${{ steps.detect-package-manager.outputs.manager }} ${{ steps.detect-package-manager.outputs.command }}
run: pnpm ci

- name: 📊 Generate dependency report
run: |
echo "# 📊 Dependency Analysis Report" >> $GITHUB_STEP_SUMMARY
echo "" >> $GITHUB_STEP_SUMMARY

# 依赖统计
total_deps=$(${{ steps.detect-package-manager.outputs.manager }} list --depth=0 --json | jq '.dependencies | length')
dev_deps=$(${{ steps.detect-package-manager.outputs.manager }} list --depth=0 --dev --json | jq '.dependencies | length // 0')
total_deps=$(pnpm list --depth=0 --json | jq '.dependencies | length')
dev_deps=$(pnpm list --depth=0 --dev --json | jq '.dependencies | length // 0')
prod_deps=$((total_deps - dev_deps))

echo "## 📈 Dependency Statistics" >> $GITHUB_STEP_SUMMARY
Expand Down
Loading