Show setup hint when rustup has no default toolchain#4912
Merged
Conversation
0xEgao
force-pushed
the
hint-for-no-toolchain
branch
from
bcc19b9 to
8adcd9b
Compare
rami3l
reviewed
Jun 16, 2026
0xEgao
force-pushed
the
hint-for-no-toolchain
branch
from
8adcd9b to
f0ad2cf
Compare
Contributor
Author
|
@rami3l Thanks for reviewing!!, Happy to contribute :D |
rami3l
reviewed
Jun 16, 2026
0xEgao
force-pushed
the
hint-for-no-toolchain
branch
2 times, most recently
from
c8870df to
e3c5a4d
Compare
rami3l
reviewed
Jun 17, 2026
rami3l
approved these changes
Jun 17, 2026
Member
There was a problem hiding this comment.
@0xEgao Thanks for the patch! I've left some small nits but looks pretty good overall :)
Also please don't forget to update the PR description to reflect the latest changes.
0xEgao
force-pushed
the
hint-for-no-toolchain
branch
from
e3c5a4d to
9743424
Compare
Member
@0xEgao LGTM :) Once you've done that I can merge it. |
Contributor
Author
Done i have update the pr description |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It intends to fix #4901
This adds in
rustupto print the default stable setup hint when a rustup command finishes in an empty setup state: no installed toolchains and no configured default toolchain.The hint reuses
DEFAULT_STABLE_HINT:Changes:
DEFAULT_STABLE_HINT.RustupSubcmd::should_warn_empty_setup()to decide which rustup commands may show the empty setup warning.DumpTestament,Self_, andCompletionas those commands are not related to toolchain state.