Improve "PoC"/"Proof of Concept" detection to match more variations.#1132
Merged
jasnow merged 3 commits intoJun 20, 2026
Merged
Conversation
This updates the RSpec check and the checks for the JSON Schemas to catch different capitalizations and also the full "Proof of Concept" phrase. And update YML files that violated the improved rule. Fixes rubysec#1131.
Member
|
Also this file: gems/camaleon_cms/GHSA-7x4w-cj9r-h4v9.yml |
jasnow
approved these changes
Jun 20, 2026
jasnow
left a comment
jasnow
left a comment
Member
There was a problem hiding this comment.
- Fetched connorshea's branch with changes.
- Diff'ed this branch against master and they look good.
- Approving this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI Disclosure: The regex was generated with Claude Code, all changes tested and reviewed manually by me.
This updates the RSpec check and the checks in the JSON Schemas to catch different capitalizations and also the full "Proof of Concept" phrase.
And update YML files that violated the improved rule.
Fixes #1131.