[tmva][sofie] Drop NumPy C API dependency from SOFIE parsers#22566
Merged
Conversation
The PyTorch parser and the parser unit tests included `<numpy/arrayobject.h>` and linked against `Python3::NumPy` purely to read tensor shapes and data pointers (`PyArray_NDIM`/`PyArray_DIM`/`PyArray_DATA`). This coupled SOFIE to a specific NumPy ABI at build/link time, even though NumPy is only ever needed at runtime to produce the arrays on the Python side. This commit repaces these uses with the generic CPython API.
Test Results 21 files 21 suites 3d 6h 48m 23s ⏱️ For more details on these failures, see this check. Results for commit 7b82602. ♻️ This comment has been updated with latest results. |
vepadulano
reviewed
Jun 11, 2026
lmoneta
approved these changes
Jun 11, 2026
Contributor
Author
|
/backport to 6.40 |
|
Preparing to backport PR #22566 to branch 6.40 requested by guitargeek |
|
This PR has been backported to branch 6.40: #22581 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PyTorch parser and the parser unit tests included
<numpy/arrayobject.h>and linked againstPython3::NumPypurely to read tensor shapes and data pointers(
PyArray_NDIM/PyArray_DIM/PyArray_DATA). This coupled SOFIE to a specific NumPy ABI at build/link time, even though NumPy is only ever needed at runtime to produce the arrays on the Python side.This commit repaces these uses with the generic CPython API.