[nfc] simplify llvm version check#22563
Merged
Merged
Conversation
Use standard cmake version check functionality rather than hand crafted regex matching. It's more compact and less bug prone
Test Results 22 files 22 suites 3d 11h 45m 46s ⏱️ For more details on these failures, see this check. Results for commit f899580. ♻️ This comment has been updated with latest results. |
hahnjo
approved these changes
Jun 11, 2026
hahnjo
left a comment
hahnjo
left a comment
Member
There was a problem hiding this comment.
LGTM 👍 as said elsewhere, in principle we could accept any 20.y.p but LLVM never had a x.2.p until now, so let's not complicate ourselves with theoretical considerations.
As suggested by hahnjo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use standard cmake version check functionality rather than hand crafted regex matching. It's more compact and less bug prone