Run validation suite on multiple versions and store them separately in folders#71
Open
undefined-panda wants to merge 6 commits into
Open
Run validation suite on multiple versions and store them separately in folders#71undefined-panda wants to merge 6 commits into
undefined-panda wants to merge 6 commits into
Conversation
ROOT files and JSON files are now written directly in designated folders.
undefined-panda
force-pushed
the
multiple-versions
branch
from
2fbdfb4 to
ff4f4be
Compare
hahnjo
reviewed
Jun 12, 2026
hahnjo
left a comment
hahnjo
left a comment
Member
There was a problem hiding this comment.
Maybe consider squashing commits 2,3,4 because only together the changes fully move dictionaries to a subdirectory. (there's also make store and move_files which is later removed again, but getting rid of that one would be an added bonus)
| all: $(DICT_DIR)/libNestedMap.so | ||
|
|
||
| $(DICT_DIR)NestedMap.cxx: NestedMap.hxx LinkDef.h | ||
| $(DICT_DIR)/NestedMap.cxx: NestedMap.hxx LinkDef.h |
Member
There was a problem hiding this comment.
I think the explicit slash (/) prevents executing make directly in that directory because it tries to create /NestedMap.cxx in the system root, which is usually not writable. It would be good to restore the ability to run individual tests, and this may work by adding the slash to DICT_DIR in the top-level Makefile.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The validation suite can now be run by specifying folders for dictionaries, ROOT binary files and JSON files created accordingly. That way the
.rootfiles generated by version X can be read by other versions to create.jsonfiles.