Skip to content

Fix nav scroll-into-view, inline beta labels, and unify colors#390

Merged
JakeSCahill merged 1 commit into
mainfrom
fix/nav-improvements
Jun 15, 2026
Merged

Fix nav scroll-into-view, inline beta labels, and unify colors#390
JakeSCahill merged 1 commit into
mainfrom
fix/nav-improvements

Conversation

@JakeSCahill

@JakeSCahill JakeSCahill commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Fix active nav item not being visible on page load by changing scrollIntoView from block: 'end' to block: 'center'
  • Fix beta/limited availability labels wrapping to new line by changing display: block to display: inline
  • Unify nav hover/active colors to indigo in light mode (top-level items were grey, now match nested items)
  • Adjust nav font size from 16px to 15px to match TOC and improve information density

Test plan

  • Navigate to a deeply nested page (e.g., /agentic-data-plane/connect/managed/salesforce/) and verify the active nav item is visible/centered
  • Verify beta labels like "(beta)" stay on the same line as nav text
  • Switch to light mode and verify hover/active states use indigo background
  • Verify nav font size looks balanced with TOC and main content

🤖 Generated with Claude Code

- Change scrollIntoView from block: 'end' to 'center' so active nav
  item is centered and visible instead of aligned to bottom
- Fix beta/limited labels to display inline instead of block so they
  stay on the same line as nav text when there's room
- Unify nav hover/active colors to indigo in light mode (was grey for
  top-level items, indigo for nested items)
- Adjust nav font size from 16px to 15px to match TOC and improve density

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@netlify

netlify Bot commented Jun 15, 2026

Copy link
Copy Markdown

Deploy Preview for docs-ui ready!

Name Link
🔨 Latest commit 3e8283a
🔍 Latest deploy log https://app.netlify.com/projects/docs-ui/deploys/6a2fe1c9583476000823bfc9
😎 Deploy Preview https://deploy-preview-390--docs-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 30 (🔴 down 2 from production)
Accessibility: 89 (no change from production)
Best Practices: 92 (no change from production)
SEO: 89 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai

coderabbitai Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

Several font-size values across src/css/nav.css are updated from 14px or 16px-relative calculations to a uniform 15px-relative calc(... * 1rem) value. Affected selectors include the brand subtitle, search button/input, search text section, dropdown menu links, nav menu title, nav item text, status footer link, and top-level parent nav item text. The cloud availability badge pseudo-elements (.nav-link.cloud-beta::after and .nav-link.cloud-limited-availability::after) are reworked from a height/background-based approach to simpler inline styling with explicit content, margin-left, and white-space properties. In the light theme, parent nav item hover and current-page states switch from grey to indigo backgrounds and text colors. In src/js/01-nav.js, scrollItemToMidpoint changes scrollIntoView from block: 'end' to block: 'center'.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the three main changes: scroll-into-view fix, inline beta labels fix, and color unification for navigation.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed The PR description clearly relates to the changeset, detailing specific fixes to navigation styling and behavior with matching code modifications.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/nav-improvements

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@JakeSCahill JakeSCahill requested a review from kbatuigas June 15, 2026 11:31

@kbatuigas kbatuigas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@JakeSCahill JakeSCahill merged commit 42fccc1 into main Jun 15, 2026
6 checks passed
@JakeSCahill JakeSCahill deleted the fix/nav-improvements branch June 15, 2026 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants