[codex] Support time-varying report risk-free rates#524
Open
luuhongyii wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
reports.html()andreports.metrics()acceptedrfas if it were always a scalar. Passing a pandas Series triggered ambiguous truth-value checks and scalar formatting failures. The underlying excess-return helper also subtracted a Series from a DataFrame along columns instead of rows, which broke date-aligned RF calculations inside reports.Fixes #521.
Testing
PYTHONUTF8=1 python -m pytest -q(129 passed)