Skip to content

gh-151278: Fix test_faulthandler on UBSan#151279

Merged
vstinner merged 1 commit into
python:mainfrom
vstinner:faulthandler
Jun 10, 2026
Merged

gh-151278: Fix test_faulthandler on UBSan#151279
vstinner merged 1 commit into
python:mainfrom
vstinner:faulthandler

Conversation

@vstinner

@vstinner vstinner commented Jun 10, 2026

Copy link
Copy Markdown
Member
  • Py_FatalError() no longer calls _PyFaulthandler_Fini() if it doesn't hold the GIL.
  • Skip test_faulthandler tests raising signals if run with UBSan.
  • Enable test_faulthandler in GitHub Action "Reusable Sanitizer".

* Py_FatalError() no longer calls _PyFaulthandler_Fini() if it
  doesn't hold the GIL.
* Skip test_faulthandler tests raising signals if run with UBSan.
* Enable test_faulthandler in GitHub Action "Reusable Sanitizer".
@vstinner vstinner added the needs backport to 3.13 bugs and security fixes label Jun 10, 2026
@vstinner vstinner added the needs backport to 3.14 bugs and security fixes label Jun 10, 2026
@vstinner vstinner requested a review from itamaro as a code owner June 10, 2026 18:45
@vstinner vstinner added the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Jun 10, 2026
@vstinner vstinner merged commit e60c42d into python:main Jun 10, 2026
61 checks passed
@vstinner vstinner deleted the faulthandler branch June 10, 2026 19:39
@miss-islington-app

Copy link
Copy Markdown

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15.
🐍🍒⛏🤖

@miss-islington-app

Copy link
Copy Markdown

Sorry, @vstinner, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker e60c42dc3f5a8dd9b10bc9a8a028ef2765469650 3.14

@miss-islington-app

Copy link
Copy Markdown

Sorry, @vstinner, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker e60c42dc3f5a8dd9b10bc9a8a028ef2765469650 3.13

@bedevere-app

bedevere-app Bot commented Jun 10, 2026

Copy link
Copy Markdown

GH-151281 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Jun 10, 2026
@bedevere-app

bedevere-app Bot commented Jun 10, 2026

Copy link
Copy Markdown

GH-151282 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jun 10, 2026
@vstinner vstinner removed the needs backport to 3.13 bugs and security fixes label Jun 10, 2026
vstinner added a commit that referenced this pull request Jun 10, 2026
gh-151278: Fix test_faulthandler on UBSan (GH-151279)

* Py_FatalError() no longer calls _PyFaulthandler_Fini() if it
  doesn't hold the GIL.
* Skip test_faulthandler tests raising signals if run with UBSan.
* Enable test_faulthandler in GitHub Action "Reusable Sanitizer".
(cherry picked from commit e60c42d)

Co-authored-by: Victor Stinner <vstinner@python.org>
vstinner added a commit that referenced this pull request Jun 10, 2026
gh-151278: Fix test_faulthandler on UBSan (#151279)

* Py_FatalError() no longer calls _PyFaulthandler_Fini() if it
  doesn't hold the GIL.
* Skip test_faulthandler tests raising signals if run with UBSan.
* Enable test_faulthandler in GitHub Action "Reusable Sanitizer".

(cherry picked from commit e60c42d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant