Skip to content

Fix Codeblock False Positives#3517

Open
SamuelRoettgermann wants to merge 8 commits into
python-discord:mainfrom
SamuelRoettgermann:fix-codeblock-false-positives
Open

Fix Codeblock False Positives#3517
SamuelRoettgermann wants to merge 8 commits into
python-discord:mainfrom
SamuelRoettgermann:fix-codeblock-false-positives

Conversation

@SamuelRoettgermann
Copy link
Copy Markdown
Contributor

@SamuelRoettgermann SamuelRoettgermann commented Jun 6, 2026

Fixes #3515

Fixes the described issue and adds some unit tests to cover common cases.

Also updates the bad_ticks error message to work with the new, more flexible, variable ticks approach.

ShaharNaveh
ShaharNaveh previously approved these changes Jun 6, 2026
Copy link
Copy Markdown

@ShaharNaveh ShaharNaveh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Copy Markdown
Member

@jb3 jb3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor typo, else LGTM

Comment thread bot/exts/info/codeblock/_parsing.py Outdated
Update regex comment

Co-authored-by: Joe Banks <joe@jb3.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

False positive faulty code block detection

3 participants