Fix np.linalg.pinv dimension inference for DataArrays#11415
Closed
C1-BA-B1-F3 wants to merge 1 commit into
Closed
Conversation
When np.linalg.pinv is called on a DataArray or Variable, the result has swapped last two dimensions. Previously, __array_wrap__ blindly preserved the original dimension names, causing a mismatch between dimension names and their actual sizes. This fix adds dimension inference in __array_wrap__ when the result shape differs from the original. It finds the permutation that maps old dimensions to new ones based on their sizes. Fixes pydata#11396
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #11396
When is called on a DataArray or Variable, the result has swapped last two dimensions (e.g., shape → ). Previously, blindly preserved the original dimension names, causing a mismatch between dimension names and their actual sizes.
Problem
Fix
Added helper function that finds the dimension permutation when shape changes. Updated to use this inference when the result shape differs from the original.
The function:
Tests