Rename compute keep-awake guard#89
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (4)
Summary by CodeRabbitDocumentation
Refactor
WalkthroughThis pull request renames the compute module's keep-awake guard from 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
|
@coderabbitai full review |
✅ Action performedFull review finished. |
Clarifies the keep-awake safety behavior in @prisma/compute and renames the scoped guard API away from scale-to-zero terminology.
Changes
ScaleToZeroGuardandScaleToZeroGuardOptionstoKeepAwakeGuardandKeepAwakeGuardOptions, including the source and test filenames.AbortSignalbehavior explicit: aborting releases the keep-awake guard only and does not cancel the underlying promise or guarded work.Why
KeepAwakeGuarddescribes the caller-visible behavior more directly than scale-to-zero terminology. The signal wording is intentionally explicit because the abort signal is a cost safety net for releasing the guard, not a cancellation mechanism for the work being waited on.