Skip to content

Migrate pnpm config to v11#88

Merged
rtbenfield merged 3 commits into
mainfrom
chore/pnpm-v11
Jun 12, 2026
Merged

Migrate pnpm config to v11#88
rtbenfield merged 3 commits into
mainfrom
chore/pnpm-v11

Conversation

@rtbenfield

@rtbenfield rtbenfield commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Updates the repository pnpm configuration for pnpm v11 compatibility after the package-manager pin moved from v10 to v11.

Changes

  • Package manager pins: Updates the root project and standalone example projects to use pnpm@11.6.0 so local and example installs do not fall back to pnpm 10.
  • Node runtime pin: Updates .node-version to the latest Node 22 release and raises the root development engine floor to >=22.13.0, matching pnpm v11's runtime requirement.
  • Example pnpm config: Moves the Next smoke postcss override out of the removed package.json#pnpm config field and into examples/next-smoke/pnpm-workspace.yaml, where pnpm v11 reads project configuration. The 8.5.10 pin preserves the existing lockfile resolution, so this migration does not downgrade the example from a newer PostCSS release.
  • Build approvals: Adds allowBuilds.esbuild: true to the root and standalone example workspaces so esbuild install scripts are explicitly approved under pnpm v11's build policy.

Why

pnpm v11 no longer reads pnpm-specific settings from the pnpm field in package.json, requires Node >=22.13, and uses allowBuilds for dependency build-script approvals. Keeping these settings in workspace config preserves the existing install behavior while making the repo compatible with v11.

@coderabbitai

coderabbitai Bot commented Jun 12, 2026

Copy link
Copy Markdown

Review Change Stack

Walkthrough

This PR upgrades pnpm from version 10.30.0 to 11.6.0 across the workspace by updating the packageManager field in the root package.json and two example project package.json files. Concurrently, the PR consolidates a postcss dependency override from the examples/next-smoke/package.json into the examples/next-smoke/pnpm-workspace.yaml workspace configuration, ensuring the dependency constraint is maintained after the pnpm upgrade.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title directly and clearly describes the main change: migrating pnpm configuration for v11 compatibility, which matches the core objective of updating package manager versions and config locations.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed The PR description clearly describes the changeset and rationale for updating pnpm configuration to v11 compatibility, matching the file changes shown in the raw summary.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/pnpm-v11
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch chore/pnpm-v11

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@examples/next-smoke/pnpm-workspace.yaml`:
- Around line 4-5: Confirm that the workspace override syntax in
pnpm-workspace.yaml is correct for pnpm v11 (the overrides.postcss key is valid)
and update the file or PR description to include a short rationale for pinning
postcss to 8.5.10 (e.g., compatibility with Next.js/other deps, security fixes,
or reproducible installs) and mention that pnpm-lock.yaml currently resolves
postcss to 8.5.10 (so this is not a downgrade from 8.5.15).
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 21936d78-b3e0-4ee7-b9ad-ee95aebb6b15

📥 Commits

Reviewing files that changed from the base of the PR and between 9424a7c and 8053dde.

📒 Files selected for processing (4)
  • examples/hello-world/package.json
  • examples/next-smoke/package.json
  • examples/next-smoke/pnpm-workspace.yaml
  • package.json

Comment thread examples/next-smoke/pnpm-workspace.yaml
@rtbenfield rtbenfield marked this pull request as draft June 12, 2026 17:50
@rtbenfield rtbenfield marked this pull request as ready for review June 12, 2026 17:59
@rtbenfield rtbenfield merged commit 4a508a2 into main Jun 12, 2026
8 checks passed
@rtbenfield rtbenfield deleted the chore/pnpm-v11 branch June 12, 2026 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant