Allow sorting file contents on windows machines#1257
Closed
TomsCodingCode wants to merge 1 commit into
Closed
Conversation
Member
|
this feature has been declined already. you can read the discussion and recommendations if you search the issue tracker for it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into this issue, because in one of our CI/CD pipeline's we run the pre-commit checks on a windows image, which would result in a puzzling output from the
file_contents_sorterhook.Before the hook would perform a
.rstrip(b'\n\r')on all lines, removing the CR character, and then join the lines together, only using'\n', resulting in white space differences that are hard to spot.With this PR the newline sequence of the first line is used to determine how to strip and join the lines before and after sorting.
Added unit tests to ensure consistent behaviour on windows.