Skip to content

Update undici#206

Merged
joshmgross merged 1 commit into
mainfrom
update-undici
Jun 3, 2026
Merged

Update undici#206
joshmgross merged 1 commit into
mainfrom
update-undici

Conversation

@joshmgross

Copy link
Copy Markdown
Contributor

This updates undici to the latest available version, resolving a couple of reported warnings in npm audit.

These issues do not apply to our usage of undici which is purely in tests that we maintain, but it's still good to stay up to date.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 3c2d0f8. Configure here.

Comment thread package.json
"ts-node": "^10.9.1",
"typescript": "^5.1.6",
"undici": "^5.8.0"
"undici": "^8.3.0"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests need newer Node

Medium Severity

Upgrading the test-only undici devDependency to v8 makes npm test depend on Node >=22.19.0, because Jest imports undici in __tests__, while engines still allows Node >=16. Environments on Node 16–22.18 that satisfied engines and worked with undici v5 can fail when loading or running tests.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 3c2d0f8. Configure here.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our tests are run with a newer version of Node, so I'm okay with this.

I do not want to stay on an old version of undici, but I don't want to unnecessarily bump the required version of Node for this package purely for a test dependency. It's likely that we should bump that to a newer version of Node that is LTS, but that's a separate discussion.

@joshmgross joshmgross enabled auto-merge June 3, 2026 20:58
@joshmgross joshmgross merged commit 9c0fe69 into main Jun 3, 2026
9 checks passed
@joshmgross joshmgross deleted the update-undici branch June 3, 2026 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants