Infer base64_decode for constant strings#5868
Closed
VincentLanglet wants to merge 1 commit into
Closed
Conversation
Contributor
Author
Contributor
|
IIRC there is a open issue in which ondrej comments that we don't want base64 decoding because its a waste of resources |
Contributor
Author
This was implemented by the bot in #5866 because of the Static Analysis failures to ensure those call are not phpstan-src/src/Analyser/NodeScopeResolver.php Line 2624 in 6afc6d4 But I think the workaround with base64 can be removed #5869 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.