Fix #2649: Catch ToString() exceptions in NUnit3 output#2697
Merged
Conversation
This was referenced Apr 3, 2026
Member
Author
|
tests |
nohwnd
force-pushed
the
fix-2649-nunit3-tostring
branch
from
f9f70da to
d19716e
Compare
Member
Author
|
🤖 Tests added in latest push — verifies NUnit3 report survives ToString() that throws. |
fflaten
reviewed
Apr 4, 2026
Comment on lines
+966
to
+975
| $typeAdded = try { [BrokenToString] } catch { $false } | ||
| if (-not $typeAdded) { | ||
| Add-Type -TypeDefinition ' | ||
| public class BrokenToString { | ||
| public override string ToString() { | ||
| throw new System.InvalidOperationException("ToString failed"); | ||
| } | ||
| } | ||
| ' | ||
| } |
Collaborator
There was a problem hiding this comment.
Replace with psobject or New-MockObject?
Member
Author
There was a problem hiding this comment.
Done at c019e53 — dropped the Add-Type C# class in favour of a [PSCustomObject] with Add-Member -MemberType ScriptMethod -Name ToString -Force whose body throws. Same test, no extra type registered per run.
nohwnd
force-pushed
the
fix-2649-nunit3-tostring
branch
from
d19716e to
1003748
Compare
Copilot-generated fix. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
nohwnd
force-pushed
the
fix-2649-nunit3-tostring
branch
from
1003748 to
c019e53
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #2649
NUnit3 report writing crashed when a test output object's
ToString()method throws. Wrapped in try/catch with a descriptive fallback string.Copilot-generated fix.
Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com