Skip to content

[FEATURE/BREAKINGCHANGE] DataQueriesProvider: use full queryDefinitions + remove QueryCountProvider + add edit query name in QueryEditorContainer#69

Open
Gladorme wants to merge 4 commits into
perses:mainfrom
Gladorme:named-queries

Conversation

@Gladorme

@Gladorme Gladorme commented Feb 26, 2026

Copy link
Copy Markdown
Member

Description

Depends on: perses/perses#3915, I will fix conflicts once merged/released.

This PR is doing some breaking changes:

  • DataQueriesProvider: need full query definitions instead of just definition (Definition => QueryDefinition)
  • QueryCountProvider: removed, you can retrieve query count using DataQueriesProvider
  • useQueryType: removed containing hard coded plugin data

This PR allow user to edit query names, using a self edit/submit button in order to not spam rerender when updating it, it's more beautiful as standard text when not collapsed (instead of textfield) and it's not something that will be changed often (imo)

Screenshots

Edit button only visible on hover, when query is collapsed
image

Always visible when query is not collapsed
image

On edit:
image

Checklist

  • Pull request has a descriptive title and context useful to a reviewer.
  • Pull request title follows the [<catalog_entry>] <commit message> naming convention using one of the
    following catalog_entry values: FEATURE, ENHANCEMENT, BUGFIX, BREAKINGCHANGE, DOC,IGNORE.
  • All commits have DCO signoffs.

UI Changes

  • Changes that impact the UI include screenshots and/or screencasts of the relevant changes.
  • Code follows the UI guidelines.
  • E2E tests are stable and unlikely to be flaky.
    See e2e docs for more details. Common issues include:
    • Is the data inconsistent? You need to mock API requests.
    • Does the time change? You need to use consistent time values or mock time utilities.
    • Does it have loading states? You need to wait for loading to complete.

…ns + remove QueryCountProvider + add edit query name in QueryEditorContainer

Signed-off-by: Guillaume LADORME <Gladorme@users.noreply.github.com>
Gladorme added 2 commits June 11, 2026 15:40
Signed-off-by: Guillaume LADORME <Gladorme@users.noreply.github.com>
Signed-off-by: Guillaume LADORME <Gladorme@users.noreply.github.com>
Signed-off-by: Guillaume LADORME <Gladorme@users.noreply.github.com>
@Gladorme Gladorme marked this pull request as ready for review June 11, 2026 14:47
@Gladorme Gladorme requested a review from a team as a code owner June 11, 2026 14:47
@celian-garcia

celian-garcia commented Jun 11, 2026

Copy link
Copy Markdown
Member

Counter proposal to be less polluting for the edit button
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants