Skip to content

[ENHANCEMENT] maintain and update the shared packages#159

Merged
shahrokni merged 1 commit into
mainfrom
export_variabledefenition_from_index
Jun 10, 2026
Merged

[ENHANCEMENT] maintain and update the shared packages#159
shahrokni merged 1 commit into
mainfrom
export_variabledefenition_from_index

Conversation

@shahrokni

@shahrokni shahrokni commented Jun 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • dashboards\src\model\VariableDefinition.ts should be exported from the index.ts
  • rolebinding schema was added
  • For DashbaordResource, ProjectMetadata from client was used,
  • The version of the spec was increased to 0.2.0-beta.2

@shahrokni shahrokni requested a review from a team as a code owner June 10, 2026 08:46
@shahrokni shahrokni force-pushed the export_variabledefenition_from_index branch from f31dd1a to aac9749 Compare June 10, 2026 10:41
@shahrokni shahrokni marked this pull request as draft June 10, 2026 12:10
@shahrokni shahrokni marked this pull request as ready for review June 10, 2026 12:23
@shahrokni shahrokni changed the title [IGNORE] export variableDefinition from index [ENHANCEMENT] maintain and update the shared package Jun 10, 2026
@shahrokni
[ENHANCEMENT] maintain and update the shared package
86e1164 
Signed-off-by: Seyed Mahmoud SHAHROKNI <seyedmahmoud.shahrokni@amadeus.com>

Signed-off-by: Seyed Mahmoud SHAHROKNI <seyedmahmoud.shahrokni@amadeus.com>

[IGNORE] use project meta data for the dashbord resource

Signed-off-by: Seyed Mahmoud SHAHROKNI <seyedmahmoud.shahrokni@amadeus.com>

Signed-off-by: Seyed Mahmoud SHAHROKNI <seyedmahmoud.shahrokni@amadeus.com>

Signed-off-by: Seyed Mahmoud SHAHROKNI <seyedmahmoud.shahrokni@amadeus.com>

Signed-off-by: Seyed Mahmoud SHAHROKNI <seyedmahmoud.shahrokni@amadeus.com>
@shahrokni shahrokni force-pushed the export_variabledefenition_from_index branch from 604b257 to 86e1164 Compare June 10, 2026 12:30
@shahrokni shahrokni changed the title [ENHANCEMENT] maintain and update the shared package [ENHANCEMENT] maintain and update the shared packages Jun 10, 2026
@shahrokni shahrokni merged commit fba7223 into main Jun 10, 2026
12 checks passed
@shahrokni shahrokni deleted the export_variabledefenition_from_index branch June 10, 2026 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jgbernalp jgbernalp jgbernalp approved these changes

@Nexucis Nexucis Awaiting requested review from Nexucis

@andreasgerstmayr andreasgerstmayr Awaiting requested review from andreasgerstmayr

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shahrokni @jgbernalp