feat: add platform-level glob scope for content libraries#333
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Thanks for the pull request, @BryanttV! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
a79d214 to
8ba4bc3
Compare
MaferMazu
left a comment
There was a problem hiding this comment.
✅ Thanks for this PR @BryanttV.
The code looks good. I ran some tests, and everything is working fine. I just have a suggestion: can we add a case to test_enforcement "for a user who manages lib teams globally -> it can assign globally"? I tested manually and worked as expected, but it would be good to have it in the unit test.
bmtcril
left a comment
There was a problem hiding this comment.
Looks good to me, nothing to add to @MaferMazu 's review. I can thumb once the test is added.
|
Thank you both very much! I just updated the tests according to the suggestion. |
Resolves: #307
Description
Add
PlatformContentLibraryGlobData, a platform-level glob scope for content libraries, completing the library counterpart to the existingPlatformCourseOverviewGlobDataExample scope keys
lib:*lib:OpenedX:*OpenedXlib:OpenedX:DemoRelated PR
Testing Instructions
To test these changes, you can check the REST API.
Use the
/api/authz/v1/roles/users/endpoint to add platform content library permissions:{ "users": ["john"], "role": "library_admin", "scopes": ["lib:*"] }Validate the permissions
/api/authz/v1/permissions/validate/me[ { "action": "content_libraries.view_library", "scope": "lib:OpenedX:CSPROB" }, { "action": "content_libraries.manage_library_team", "scope": "lib:OpenedX:CSPROB2" }, { "action": "content_libraries.edit_library_collection", "scope": "lib:any-org:any-slug" } ]Response
[ { "action": "content_libraries.view_library", "scope": "lib:OpenedX:CSPROB", "allowed": true }, { "action": "content_libraries.manage_library_team", "scope": "lib:OpenedX:CSPROB2", "allowed": true }, { "action": "content_libraries.edit_library_collection", "scope": "lib:any-org:any-slug", "allowed": true } ]Merge checklist
Check off if complete or not applicable: