Dropoctets validation to be inline with droppkts#3402
Open
bkreddy143 wants to merge 6 commits into
Open
Conversation
1. Modified the Drop octets validation to be inline with dropped pkts.
It was validating based on OTG packets diff and packet size , instead
changed to check for 0 as drops are not expected to be seen.
"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia’s intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."
Pull Request Functional Test Report for #3402 / 51514a3Virtual Devices
Hardware Devices
|
Pull Request Test Coverage Report for Build 10586436326Details
💛 - Coveralls |
nsadhasivam
requested changes
Aug 29, 2024
Member
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the TestBurstyTraffic function in bursty_traffic_test.go. It simplifies the verification of dropped octets on the DUT when deviations.QOSDroppedOctets(dut) is false. Specifically, it removes the calculation of ateDropOctetCounterDiff and instead asserts that dutDropOctetCounterDiff must be exactly 0. No review comments were provided for this change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modified the Drop octets validation to be inline with dropped pkts validation. It was validating based on OTG packets diff and packet size , instead changed to check for 0 as drops are not expected to be seen. Also removed deviation for Nokia and updated other checks as per comments
"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia’s intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."