[v24.x] Revert "stream: noop pause/resume on destroyed streams"#63834
[v24.x] Revert "stream: noop pause/resume on destroyed streams"#63834sxa wants to merge 1 commit into
Conversation
This reverts commit 29b1966. Signed-off-by: Stewart X Addison <sxa@ibm.com>
|
Review requested:
|
|
Revert on top of v24.x-staging confirmed to have resolved the problem on my local system therefore I am taking this out of draft status. |
|
FYI @nodejs/tsc @nodejs/releasers |
|
Successfully tested against cypress@15.15.0👍🏻 Cypress already produced a fix for this issue in cypress@15.16.0 so I'm testing against the previous unfixed version cypress@15.15.0. The Cypress analysis of why it was failing on Windows (always) and Linux (when no VerificationOn Windows 11 25H2, in Git Bash with Node.js v24.16.1-pre, built from #63834, installed cd $(mktemp -d)
npm install cypress@15.15.0 --ignore-scripts # fixed versions >=15.16.0
npx cypress install --force
npx cypress verifyLogs$ cd $(mktemp -d)
npm install cypress@15.15.0 --ignore-scripts # fixed versions >=15.16.0
npx cypress install --force
npx cypress verify
npm warn cli npm v11.7.0 does not support Node.js v24.16.1-pre. This version of npm supports the following node versions: `^20.17.0 || >=22.9.0`. You can find the latest version at https://nodejs.org/.
added 175 packages in 6s
53 packages are looking for funding
run `npm fund` for details
npm warn cli npm v11.7.0 does not support Node.js v24.16.1-pre. This version of npm supports the following node versions: `^20.17.0 || >=22.9.0`. You can find the latest version at https://nodejs.org/.
Cypress 15.15.0 is installed in C:\Users\mikem\AppData\Local\Cypress\Cache\15.15.0
Installing Cypress (version: 15.15.0)
√ Downloaded Cypress
√ Unzipped Cypress
√ Finished Installation C:\Users\mikem\AppData\Local\Cypress\Cache\15.15.0
You can now open Cypress by running one of the following, depending on your package manager:
- npx cypress open
- yarn cypress open
- pnpm cypress open
https://on.cypress.io/opening-the-app
npm warn cli npm v11.7.0 does not support Node.js v24.16.1-pre. This version of npm supports the following node versions: `^20.17.0 || >=22.9.0`. You can find the latest version at https://nodejs.org/.
√ Verified Cypress! C:\Users\mikem\AppData\Local\Cypress\Cache\15.15.0\Cypress |
This reverts commit 29b1966 from #62557
Should fix #63487 based on a
git bisectrun