Skip to content

prevent early exception on NeonClient error event#141

Open
andyjy wants to merge 1 commit into
neondatabase:mainfrom
andyjy:prevent-early-exception-on-error
Open

prevent early exception on NeonClient error event#141
andyjy wants to merge 1 commit into
neondatabase:mainfrom
andyjy:prevent-early-exception-on-error

Conversation

@andyjy

@andyjy andyjy commented Feb 1, 2025

Copy link
Copy Markdown
Contributor

Diagnoses/fixes #140

Not sure whether this is the perfect solution, but sharing my temporary patch..

@andyjy

andyjy commented Feb 11, 2025

Copy link
Copy Markdown
Contributor Author

Noting here that when I next upgrade to a future release I will update this patch to apply on top of the refactor that just landed.

As mentioned above I am less than 100% sure whether this is the right/best fix to actually merge to fix the linked issue.

@jawj

jawj commented Feb 13, 2025

Copy link
Copy Markdown
Collaborator

Hmm, thanks. No, I'm also not immediately sure whether this — listen-and-do-nothing — is the right approach. Presumably we've just inherited this error behaviour from node-postgres? I'll keep this issue open for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Certain errors terminate process async with unhelpful error (e.g. incorrect user and/or password)

3 participants